Roll chromium_revision d66326c..4df108a (367167:367307)

Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/common.gypi
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7662a
DEPS diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org, perkj@webrtc.org
NOTRY=True

Committed: https://crrev.com/60ca31bf5d206ff01b5441639806f7303365e162
Cr-Commit-Position: refs/heads/master@{#11147}

[kjellander_webrtc, 2016-01-02 19:02:48]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-01-02 19:02:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553033002/1

[commit-bot: I haz the power, 2016-01-02 19:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 19:04:49]

Try jobs failed on following builders:
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[kjellander_webrtc, 2016-01-02 20:46:24]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-01-02 20:46:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553033002/20001

[commit-bot: I haz the power, 2016-01-02 20:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 20:48:15]

Try jobs failed on following builders:
  mac_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_dbg/builds/6250)

[kjellander_webrtc, 2016-01-02 21:08:28]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-02 21:08:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553033002/40001

[commit-bot: I haz the power, 2016-01-02 21:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 21:10:33]

Dry run: Try jobs failed on following builders:
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/11641)
  linux_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[kjellander_webrtc, 2016-01-03 18:39:32]

Description was changed from

==========
Roll chromium_revision d66326c..2d9b404 (367167:367282)

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..2d9b404
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404/DEPS

No update to Clang.

TBR=
==========

to

==========
Roll chromium_revision d66326c..2d9b404 (367167:367282)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..2d9b404
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404/DEPS

No update to Clang.

TBR=
BUG=
==========

[kjellander_webrtc, 2016-01-03 21:05:14]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-03 21:05:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553033002/80001

[commit-bot: I haz the power, 2016-01-03 21:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-03 21:07:09]

Dry run: Try jobs failed on following builders:
  linux_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_dbg/builds/7733)

[kjellander_webrtc, 2016-01-04 08:20:50]

https://codereview.webrtc.org/1553033002/diff/80001/third_party/gflags/BUILD.gn
File third_party/gflags/BUILD.gn (right):

https://codereview.webrtc.org/1553033002/diff/80001/third_party/gflags/BUILD....
third_party/gflags/BUILD.gn:57: cflags += [ "-Wno-unused-local-typedef" ]
Hmm, this still fails even if -Wno-unused-local-typedef is passed on the command
line to the failing compile.

[kjellander_webrtc, 2016-01-04 15:02:35]

Description was changed from

==========
Roll chromium_revision d66326c..2d9b404 (367167:367282)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..2d9b404
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..2d9b404/DEPS

No update to Clang.

TBR=
BUG=
==========

to

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG= (currently not possible to create new bugs, will do before submitting this
CL).
==========

[kjellander_webrtc, 2016-01-04 15:02:35]

kjellander@webrtc.org changed reviewers:
+ pbos@webrtc.org

[kjellander_webrtc, 2016-01-04 15:10:32]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 15:10:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553033002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553033002/170001

[kjellander_webrtc, 2016-01-04 15:17:02]

kjellander@webrtc.org changed reviewers:
+ hta@webrtc.org

[kjellander_webrtc, 2016-01-04 15:17:03]

Adding Peter since he helped me with
talk/app/webrtc/java/jni/androidvideocapturer_jni.h and
webrtc/base/latebindingsymboltable_unittest.cc

I will file bugs as soon the issue tracker is functional and reference them
where I've disabled warnings.

https://codereview.webrtc.org/1553033002/diff/150001/talk/app/webrtc/peerconn...
File talk/app/webrtc/peerconnectionendtoend_unittest.cc (left):

https://codereview.webrtc.org/1553033002/diff/150001/talk/app/webrtc/peerconn...
talk/app/webrtc/peerconnectionendtoend_unittest.cc:53: void
RemoveLinesFromSdp(const std::string& line_start,
dead code.

https://codereview.webrtc.org/1553033002/diff/150001/talk/app/webrtc/webrtcse...
File talk/app/webrtc/webrtcsession_unittest.cc (left):

https://codereview.webrtc.org/1553033002/diff/150001/talk/app/webrtc/webrtcse...
talk/app/webrtc/webrtcsession_unittest.cc:174: // Add some extra |newlines| to
the |message| after |line|.
dead code.

https://codereview.webrtc.org/1553033002/diff/150001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1553033002/diff/150001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:363: # Ref..
Will add bug link once the issue tracker is back up.

https://codereview.webrtc.org/1553033002/diff/150001/webrtc/base/linux.cc
File webrtc/base/linux.cc (left):

https://codereview.webrtc.org/1553033002/diff/150001/webrtc/base/linux.cc#old...
webrtc/base/linux.cc:236: #if !defined(WEBRTC_CHROMIUM_BUILD)
dead code.

[pbos-webrtc, 2016-01-04 15:39:05]

lgtm since iiuc render_egl_context_ won't be destroyed before something else by
going out of scope (according to the comment I think)

[commit-bot: I haz the power, 2016-01-04 16:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 16:08:53]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-01-04 17:55:34]

Description was changed from

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG= (currently not possible to create new bugs, will do before submitting this
CL).
==========

to

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
==========

[kjellander_webrtc, 2016-01-04 17:56:06]

Description was changed from

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
==========

to

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org, perkj@webrtc.org
NOTRY=True
==========

[kjellander_webrtc, 2016-01-04 17:56:07]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-01-04 18:14:03]

On 2016/01/04 16:08:53, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I'm going to TBR PS#11 to unblock rolling forward. PS#10 passed all trybots and
PS#11 only adds bug references.
hta/perkj: Please take a look at the code changes so there's nothing risky being
changed (shouldn't be).

[kjellander_webrtc, 2016-01-04 18:14:32]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-01-04 18:14:33]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1553033002/#ps190001 (title:
"Added references to bugs.")

[commit-bot: I haz the power, 2016-01-04 18:14:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553033002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553033002/190001

[commit-bot: I haz the power, 2016-01-04 18:15:56]

Description was changed from

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org, perkj@webrtc.org
NOTRY=True
==========

to

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org, perkj@webrtc.org
NOTRY=True
==========

[commit-bot: I haz the power, 2016-01-04 18:15:57]

Committed patchset #11 (id:190001)

[commit-bot: I haz the power, 2016-01-04 18:16:13]

Description was changed from

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org, perkj@webrtc.org
NOTRY=True
==========

to

==========
Roll chromium_revision d66326c..4df108a (367167:367307)

The changes in
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/build/commo...
enables a lot more warnings, which have been disabled/fixed in this CL.
See tracking bugs for remaining work.

Change log: https://chromium.googlesource.com/chromium/src/+log/d66326c..4df108a
Full diff: https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a

Changed dependencies:
* src/buildtools:
https://chromium.googlesource.com/chromium/buildtools.git/+log/fee7f1e..6d0c448
* src/third_party/libsrtp:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b8dd754..8a7...
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/d66326c..4df108a/DEPS

No update to Clang.

BUG=webrtc:5397, webrtc:5398, webrtc:5399
TBR=hta@webrtc.org, perkj@webrtc.org
NOTRY=True

Committed: https://crrev.com/60ca31bf5d206ff01b5441639806f7303365e162
Cr-Commit-Position: refs/heads/master@{#11147}
==========

[commit-bot: I haz the power, 2016-01-04 18:16:14]

Patchset 11 (id:??) landed as
https://crrev.com/60ca31bf5d206ff01b5441639806f7303365e162
Cr-Commit-Position: refs/heads/master@{#11147}

[hta-webrtc, 2016-01-05 09:01:51]

lgtm

CC changes seems to be mostly deletions. I assume the bots would have caught it
if they were used in some other configuration.

Going a bit out on a limb here (not my code), but LGTM.