Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/gflags/BUILD.gn

Issue 1553033002: Roll chromium_revision d66326c..4df108a (367167:367307) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: More libjingle warning fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/media/devices/carbonvideorenderer.cc ('k') | third_party/gflags/gflags.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 if (is_win) { 9 if (is_win) {
10 gflags_gen_arch_root = "gen/win" 10 gflags_gen_arch_root = "gen/win"
11 } else { 11 } else {
12 gflags_gen_arch_root = "gen/posix" 12 gflags_gen_arch_root = "gen/posix"
13 } 13 }
14 14
15 config("gflags_config") { 15 config("gflags_config") {
16 include_dirs = [ 16 include_dirs = [
17 "$gflags_gen_arch_root/include", # For configured files. 17 "$gflags_gen_arch_root/include", # For configured files.
18 "src", # For everything else. 18 "src", # For everything else.
19 ] 19 ]
20 20
21 defines = [ 21 defines = [
22 # These macros exist so flags and symbols are properly exported when 22 # These macros exist so flags and symbols are properly exported when
23 # building DLLs. Since we don't build DLLs, we need to disable them. 23 # building DLLs. Since we don't build DLLs, we need to disable them.
24 "GFLAGS_DLL_DECL=", 24 "GFLAGS_DLL_DECL=",
25 "GFLAGS_DLL_DECLARE_FLAG=", 25 "GFLAGS_DLL_DECLARE_FLAG=",
26 "GFLAGS_DLL_DEFINE_FLAG=", 26 "GFLAGS_DLL_DEFINE_FLAG=",
27 ] 27 ]
28 } 28 }
29 29
30 source_set("gflags") { 30 source_set("gflags") {
31 sources = [ 31 sources = [
32 "src/gflags.cc", 32 "src/gflags.cc",
33 "src/gflags_completions.cc", 33 "src/gflags_completions.cc",
34 "src/gflags_reporting.cc", 34 "src/gflags_reporting.cc",
35 ] 35 ]
36 cflags = []
36 if (is_win) { 37 if (is_win) {
37 sources += [ "src/windows/port.cc" ] 38 sources += [ "src/windows/port.cc" ]
38 39
39 cflags = [ 40 cflags += [
40 "/wd4005", # WIN32_LEAN_AND_MEAN. 41 "/wd4005", # WIN32_LEAN_AND_MEAN.
41 "/wd4267", # Conversion from size_t to "type". 42 "/wd4267", # Conversion from size_t to "type".
42 ] 43 ]
43 } 44 }
44 45
45 include_dirs = [ 46 include_dirs = [ "$gflags_gen_arch_root/include/private" ] # For config.h
46 "$gflags_gen_arch_root/include/private", # For config.h
47 ]
48 47
49 public_configs = [ ":gflags_config" ] 48 public_configs = [ ":gflags_config" ]
50 49
51 configs -= [ "//build/config/compiler:chromium_code" ] 50 configs -= [ "//build/config/compiler:chromium_code" ]
52 configs += [ "//build/config/compiler:no_chromium_code" ] 51 configs += [ "//build/config/compiler:no_chromium_code" ]
53 52
54 if (is_clang) { 53 if (is_clang) {
55 # TODO(andrew): Look into fixing this warning upstream: 54 # TODO(andrew): Look into fixing this warning upstream:
56 # http://code.google.com/p/webrtc/issues/detail?id=760 55 # http://code.google.com/p/webrtc/issues/detail?id=760
57 configs -= [ "//build/config/clang:extra_warnings" ] 56 configs -= [ "//build/config/clang:extra_warnings" ]
57 cflags += [ "-Wno-unused-local-typedef" ]
kjellander_webrtc 2016/01/04 08:20:50 Hmm, this still fails even if -Wno-unused-local-ty
58 } 58 }
59 } 59 }
OLDNEW
« no previous file with comments | « talk/media/devices/carbonvideorenderer.cc ('k') | third_party/gflags/gflags.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698