Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1537923003: Fix pointer compare-and-swap on Windows. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, åsapersson
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix pointer compare-and-swap on Windows. Incorrect argument order, also added unittest which should've been there in the first place. Also renames AtomicLoadPtr to AcquireLoadPtr to match non-ptr version. BUG= R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/455a252453eac87853acb776f08d0da773ad8079

Patch Set 1 #

Patch Set 2 : fix argument order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M webrtc/base/atomicops.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/criticalsection_unittest.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M webrtc/base/event_tracer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
pbos-webrtc
fix argument order
5 years ago (2015-12-18 13:58:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537923003/20001
5 years ago (2015-12-18 13:59:14 UTC) #4
pbos-webrtc
PTAL, thanks asapersson@ for catching this.
5 years ago (2015-12-18 13:59:29 UTC) #5
tommi
gaa... lgtm! Thanks Asa!
5 years ago (2015-12-18 14:09:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537923003/20001
5 years ago (2015-12-18 14:12:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-18 15:59:39 UTC) #12
pbos-webrtc
Committed patchset #2 (id:20001) manually as 455a252453eac87853acb776f08d0da773ad8079 (presubmit successful).
5 years ago (2015-12-18 16:00:39 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-18 16:00:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/455a252453eac87853acb776f08d0da773ad8079
Cr-Commit-Position: refs/heads/master@{#11086}

Powered by Google App Engine
This is Rietveld 408576698