webrtc/base/event_tracer.cc - Issue 1537923003: Fix pointer compare-and-swap on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/event_tracer.cc

Issue 1537923003: Fix pointer compare-and-swap on Windows. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: fix argument order Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/event_tracer.cc

diff --git a/webrtc/base/event_tracer.cc b/webrtc/base/event_tracer.cc

index 4f3df82a598fa0416caa2415a93a5d887ba41ddd..4174589d366a48cf4d20d7cc1bceb8fc0eb3ca4f 100644

--- a/webrtc/base/event_tracer.cc

+++ b/webrtc/base/event_tracer.cc

@@ -257,7 +257,7 @@ void StopInternalCapture() {

void ShutdownInternalTracer() {

StopInternalCapture();

- EventLogger* old_logger = rtc::AtomicOps::AtomicLoadPtr(&g_event_logger);

+ EventLogger* old_logger = rtc::AtomicOps::AcquireLoadPtr(&g_event_logger);

RTC_DCHECK(old_logger);

RTC_CHECK(rtc::AtomicOps::CompareAndSwapPtr(

&g_event_logger, old_logger,

« no previous file with comments | « webrtc/base/criticalsection_unittest.cc ('k') | no next file » | no next file with comments »