Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1533913004: Revert of Added option to specify a maximum file size when recording an AEC dump. (Closed)

Created:
5 years ago by ivoc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added option to specify a maximum file size when recording an AEC dump. (patchset #5 id:120001 of https://codereview.webrtc.org/1413483003/ ) Reason for revert: Breaks Chrome-FYI bots because of a change in the StartDebugRecording function in audio_processing.h, that is called from Chrome. Original issue's description: > Added option to specify a maximum file size when recording an AEC dump. > > For applications with a strict filesize limit for debug files, > I added an option to specify a maximum filesize for AEC dumps. An > existing unit test is extended to check that the feature works as > advertised. > > BUG=webrtc:4741 > TBR=glaznev@webrtc.org > > Committed: https://crrev.com/ae2c5ad12afc8cc29fe9c59dea432b697b871a87 > Cr-Commit-Position: refs/heads/master@{#11081} TBR=pthatcher@webrtc.org,henrik.lundin@webrtc.org,henrikg@webrtc.org,solenberg@webrtc.org,andrew@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org,glaznev@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4741 Committed: https://crrev.com/36d4c545007129446e551c45c17b25377dce89a4 Cr-Commit-Position: refs/heads/master@{#11087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -137 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +3 lines, -4 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactoryproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +3 lines, -5 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 chunk +1 line, -3 lines 0 comments Download
M talk/media/base/mediaengine.h View 2 chunks +4 lines, -6 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 chunk +2 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +2 lines, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 chunk +2 lines, -4 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 3 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 13 chunks +4 lines, -28 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 9 chunks +11 lines, -34 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ivoc
Created Revert of Added option to specify a maximum file size when recording an AEC ...
5 years ago (2015-12-18 16:04:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533913004/1
5 years ago (2015-12-18 16:05:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 16:05:20 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-18 16:05:25 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36d4c545007129446e551c45c17b25377dce89a4
Cr-Commit-Position: refs/heads/master@{#11087}

Powered by Google App Engine
This is Rietveld 408576698