Update/move RTCVideoRendererAdapter to webrtc/api/objc.

Update/move RTCVideoRendererAdapter to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/891a446a920bb7d51b8d17bae071f44d591ee5e2
Patch from Jon Hjelle <hjon@andyet.net>;.

Cr-Commit-Position: refs/heads/master@{#11347}

[hjon, 2015-12-22 16:58:05]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-01-05 21:59:02]

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
File webrtc/api/objc/RTCVideoRendererAdapter.h (right):

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.h:17: @interface RTCVideoRendererAdapter
: NSObject
doco what this class is used for + update property comments.

e.g.
Creates a webrtc::VideoRendererInterface surface for an RTCVideoRenderer. The
webrtc::VideoRendererInterface is used by WebRTC rendering code - this adapter
adapts calls made to that interface to the RTCVideoRenderer supplied during
construction.

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.h:17: @interface RTCVideoRendererAdapter
: NSObject
Consider putting this in RTCVideoRenderer+Private.h
(We've been putting anything that deals with C++ in private headers)

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.h:22: /** The native
VideoRendererInterface representing this adapter. */
doco: pointer is unsafe and owned by this class

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.mm:28: [_adapter.videoRenderer
setSize:_size];
Do we need setSize? If C++ impl junked it maybe we should too. What does Android
do?

[hjon, 2016-01-08 01:00:52]

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
File webrtc/api/objc/RTCVideoRendererAdapter.h (right):

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.h:17: @interface RTCVideoRendererAdapter
: NSObject
On 2016/01/05 21:59:02, tkchin_webrtc wrote:
> Consider putting this in RTCVideoRenderer+Private.h
> (We've been putting anything that deals with C++ in private headers)

Done.

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.h:22: /** The native
VideoRendererInterface representing this adapter. */
On 2016/01/05 21:59:02, tkchin_webrtc wrote:
> doco: pointer is unsafe and owned by this class

Done.

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/1/webrtc/api/objc/RTCVideoRende...
webrtc/api/objc/RTCVideoRendererAdapter.mm:28: [_adapter.videoRenderer
setSize:_size];
On 2016/01/05 21:59:02, tkchin_webrtc wrote:
> Do we need setSize? If C++ impl junked it maybe we should too. What does
Android
> do?

Looks like the only thing setSize does in the renderer's implementation is
notify delegates that the size changed. From what I can see in digging around in
Android a bit, there appears to be a similar kind of notification about the size
changing. It seems that it may be useful to provide this information about the
size changing for layout purposes. What do you think about putting this logic in
the renderer instead?

[tkchin_webrtc, 2016-01-14 01:43:33]

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
File webrtc/api/objc/RTCVideoRendererAdapter+Private.h (right):

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
webrtc/api/objc/RTCVideoRendererAdapter+Private.h:13: #include
"talk/app/webrtc/mediastreaminterface.h"
mediastreaminterface?

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
webrtc/api/objc/RTCVideoRendererAdapter.mm:18: class
RTCVideoRendererNativeAdapter : public VideoRendererInterface {
nit: already namespaced in webrtc. 
class VideoRendererAdapter should be fine.

[hjon, 2016-01-14 18:48:52]

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
File webrtc/api/objc/RTCVideoRendererAdapter+Private.h (right):

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
webrtc/api/objc/RTCVideoRendererAdapter+Private.h:13: #include
"talk/app/webrtc/mediastreaminterface.h"
On 2016/01/14 01:43:32, tkchin_webrtc wrote:
> mediastreaminterface?

Yeah, it seems a bit odd, but that's where VideoRendererInterface is defined.

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/80001/webrtc/api/objc/RTCVideoR...
webrtc/api/objc/RTCVideoRendererAdapter.mm:18: class
RTCVideoRendererNativeAdapter : public VideoRendererInterface {
On 2016/01/14 01:43:32, tkchin_webrtc wrote:
> nit: already namespaced in webrtc. 
> class VideoRendererAdapter should be fine.

Done.

[tkchin_webrtc, 2016-01-20 21:45:23]

lgtm

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:13: #import
"webrtc/api/objc/RTCVideoRendererAdapter+Private.h"
alphabetical

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:20:
VideoRendererAdapter(RTCVideoRendererAdapter *adapter) {
RTCVideoRendererAdapter* adapter (C++ rules in C++ code)

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:28: CGSize currentSize =
CGSizeMake(frame->GetWidth(), frame->GetHeight());
current_size

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:39: __weak RTCVideoRendererAdapter
*_adapter;
adapter_
size_

[hjon, 2016-01-20 21:48:25]

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:13: #import
"webrtc/api/objc/RTCVideoRendererAdapter+Private.h"
On 2016/01/20 21:45:22, tkchin_webrtc wrote:
> alphabetical

Done.

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:20:
VideoRendererAdapter(RTCVideoRendererAdapter *adapter) {
On 2016/01/20 21:45:23, tkchin_webrtc wrote:
> RTCVideoRendererAdapter* adapter (C++ rules in C++ code)

Done.

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:28: CGSize currentSize =
CGSizeMake(frame->GetWidth(), frame->GetHeight());
On 2016/01/20 21:45:23, tkchin_webrtc wrote:
> current_size

Done.

https://codereview.webrtc.org/1533323003/diff/140001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:39: __weak RTCVideoRendererAdapter
*_adapter;
On 2016/01/20 21:45:23, tkchin_webrtc wrote:
> adapter_
> size_

Done.

[tkchin_webrtc, 2016-01-20 22:14:16]

https://codereview.webrtc.org/1533323003/diff/180001/webrtc/api/objc/RTCVideo...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/180001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:28: CGSize currentsize_ =
CGSizeMake(frame->GetWidth(), frame->GetHeight());
current_size

[hjon_webrtc, 2016-01-20 22:28:00]

hjon@webrtc.org changed reviewers:
+ hjon@webrtc.org

[hjon_webrtc, 2016-01-20 22:28:00]

https://codereview.webrtc.org/1533323003/diff/180001/webrtc/api/objc/RTCVideo...
File webrtc/api/objc/RTCVideoRendererAdapter.mm (right):

https://codereview.webrtc.org/1533323003/diff/180001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoRendererAdapter.mm:28: CGSize currentsize_ =
CGSizeMake(frame->GetWidth(), frame->GetHeight());
On 2016/01/20 22:14:16, tkchin_webrtc wrote:
> current_size

Done.

[tkchin_webrtc, 2016-01-21 19:42:14]

Description was changed from

==========
Update/move RTCVideoRendererAdapter to webrtc/api/objc.

BUG=
==========

to

==========
Update/move RTCVideoRendererAdapter to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/891a446a920bb7d51b8d17bae...
==========

[tkchin_webrtc, 2016-01-21 19:42:15]

Committed patchset #11 (id:200001) manually as
891a446a920bb7d51b8d17bae071f44d591ee5e2 (presubmit successful).

[commit-bot: I haz the power, 2016-01-21 19:42:19]

Description was changed from

==========
Update/move RTCVideoRendererAdapter to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/891a446a920bb7d51b8d17bae...
==========

to

==========
Update/move RTCVideoRendererAdapter to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/891a446a920bb7d51b8d17bae071f44d591ee5e2
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11347}
==========

[commit-bot: I haz the power, 2016-01-21 19:42:20]

Patchset 11 (id:??) landed as
https://crrev.com/891a446a920bb7d51b8d17bae071f44d591ee5e2
Cr-Commit-Position: refs/heads/master@{#11347}