Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1530913002: Rename RTC_HISTOGRAM_* macros to RTC_HISTOGRAM_*_SPARSE_* to indicate that these are for infrequent (Closed)

Created:
5 years ago by åsapersson
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, peah-webrtc, andresp, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename RTC_HISTOGRAM_* macros to RTC_HISTOGRAM_*_SPARSE_* to indicate that these are for infrequent updates. This implementation will be replaced by a faster one and sparse will be removed. BUG=webrtc:5283 Committed: https://crrev.com/53805324c0fa904d796cc0b333868c591f2c5f2c Cr-Commit-Position: refs/heads/master@{#11099}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -130 lines) Patch
M webrtc/call/call.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/statistics_calculator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/timing.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/system_wrappers/include/metrics.h View 1 1 chunk +21 lines, -22 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 1 chunk +11 lines, -9 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 chunks +25 lines, -18 lines 0 comments Download
M webrtc/video/vie_channel.cc View 6 chunks +39 lines, -30 lines 0 comments Download
M webrtc/video/vie_receiver.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
åsapersson
5 years ago (2015-12-16 14:26:38 UTC) #4
hlundin-webrtc
lgtm for webrtc/modules/audio_* and webrtc/modules/bitrate_controller We should probably reconsider the UMA logging in webrtc/modules/audio_coding/neteq/statistics_calculator.cc; it ...
5 years ago (2015-12-16 16:28:59 UTC) #5
pbos-webrtc
lgtm but please put why in the description (that the implementation is slow due to ...
5 years ago (2015-12-18 14:55:52 UTC) #7
åsapersson
On 2015/12/18 14:55:52, pbos-webrtc wrote: > lgtm but please put why in the description (that ...
5 years ago (2015-12-18 15:05:18 UTC) #10
mflodman
LGTM
5 years ago (2015-12-21 08:25:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530913002/40001
5 years ago (2015-12-21 08:30:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-21 09:46:25 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-21 09:46:44 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53805324c0fa904d796cc0b333868c591f2c5f2c
Cr-Commit-Position: refs/heads/master@{#11099}

Powered by Google App Engine
This is Rietveld 408576698