webrtc/modules/audio_coding/neteq/statistics_calculator.cc - Issue 1530913002: Rename RTC_HISTOGRAM_* macros to RTC_HISTOGRAM_*_SPARSE_* to indicate that these are for infrequent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/statistics_calculator.cc

Issue 1530913002: Rename RTC_HISTOGRAM_* macros to RTC_HISTOGRAM_*_SPARSE_* to indicate that these are for infrequent (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc ('k') | webrtc/modules/audio_processing/audio_processing_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/statistics_calculator.cc

diff --git a/webrtc/modules/audio_coding/neteq/statistics_calculator.cc b/webrtc/modules/audio_coding/neteq/statistics_calculator.cc

index e6a6fbf705577646604973169d3c9feaec9f9916..8f873762c51c7063ffdd700b013e42efcb71611c 100644

--- a/webrtc/modules/audio_coding/neteq/statistics_calculator.cc

+++ b/webrtc/modules/audio_coding/neteq/statistics_calculator.cc

@@ -50,7 +50,7 @@ void StatisticsCalculator::PeriodicUmaLogger::AdvanceClock(int step_ms) {

}

void StatisticsCalculator::PeriodicUmaLogger::LogToUma(int value) const {

- RTC_HISTOGRAM_COUNTS(uma_name_, value, 1, max_value_, 50);

+ RTC_HISTOGRAM_COUNTS_SPARSE(uma_name_, value, 1, max_value_, 50);

}

StatisticsCalculator::PeriodicUmaCount::PeriodicUmaCount(

@@ -187,9 +187,9 @@ void StatisticsCalculator::SecondaryDecodedSamples(int num_samples) {

}

void StatisticsCalculator::LogDelayedPacketOutageEvent(int outage_duration_ms) {

- RTC_HISTOGRAM_COUNTS("WebRTC.Audio.DelayedPacketOutageEventMs",

- outage_duration_ms, 1 /* min */, 2000 /* max */,

- 100 /* bucket count */);

+ RTC_HISTOGRAM_COUNTS_SPARSE("WebRTC.Audio.DelayedPacketOutageEventMs",

+ outage_duration_ms, 1 /* min */, 2000 /* max */,

+ 100 /* bucket count */);

delayed_packet_outage_counter_.RegisterSample();

}