Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1528043002: Revert of Base webrtc fuzzers on a template. (Closed)

Created:
5 years ago by tommi
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) Reason for revert: Suspect this is breaking the build: https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio Original issue's description: > Base webrtc fuzzers on a template. > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > BUG=webrtc:4771 > R=kjellander@webrtc.org > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > Cr-Commit-Position: refs/heads/master@{#11022} TBR=kjellander@webrtc.org,pbos@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 Cr-Commit-Position: refs/heads/master@{#11032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -36 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 6 chunks +31 lines, -8 lines 0 comments Download
D webrtc/test/fuzzers/webrtc_fuzzer.gni View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tommi
Created Revert of Base webrtc fuzzers on a template.
5 years ago (2015-12-15 18:23:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528043002/1
5 years ago (2015-12-15 18:23:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 18:24:00 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 Cr-Commit-Position: refs/heads/master@{#11032}
5 years ago (2015-12-15 18:24:13 UTC) #6
pbos-webrtc
lgtm
5 years ago (2015-12-15 20:53:26 UTC) #7
pbos-webrtc
5 years ago (2015-12-15 20:54:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1522003005/ by pbos@webrtc.org.

The reason for reverting is: Found missing public_configs that broke Chromium
libfuzzer build..

Powered by Google App Engine
This is Rietveld 408576698