AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028
Committed: https://crrev.com/44307630d3ad6dcdd7b7fd07e78881b50a92ced4
Cr-Commit-Position: refs/heads/master@{#11051}

[kwiberg-webrtc, 2015-12-15 11:58:33]

Description was changed from

==========
AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028
==========

to

==========
AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028
==========

[kwiberg-webrtc, 2015-12-15 11:58:33]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2015-12-15 11:59:12]

PTAL

https://codereview.webrtc.org/1527453005/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/acm2/codec_manager.cc (right):

https://codereview.webrtc.org/1527453005/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/acm2/codec_manager.cc:170: // encoder.
Henrik, this is the thing I brought up at lunch. The current CL doesn't change
this behavior.

[hlundin-webrtc, 2015-12-15 13:46:36]

lgtm

https://codereview.webrtc.org/1527453005/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/acm2/codec_manager.cc (right):

https://codereview.webrtc.org/1527453005/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/acm2/codec_manager.cc:170: // encoder.
On 2015/12/15 11:59:12, kwiberg-webrtc wrote:
> Henrik, this is the thing I brought up at lunch. The current CL doesn't change
> this behavior.

Acknowledged.

[kwiberg-webrtc, 2015-12-16 13:28:53]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-12-16 13:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1527453005/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-12-16 13:29:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527453005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527453005/40001

[commit-bot: I haz the power, 2015-12-16 13:35:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 13:35:02]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2458)

[kwiberg-webrtc, 2015-12-16 13:42:22]

kwiberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[kwiberg-webrtc, 2015-12-16 13:42:47]

Fredrik, can you take a look too?

[the sun, 2015-12-16 13:51:06]

lgtm for voe

[kwiberg-webrtc, 2015-12-16 14:03:16]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-12-16 14:03:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527453005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527453005/40001

[commit-bot: I haz the power, 2015-12-16 14:24:08]

Description was changed from

==========
AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028
==========

to

==========
AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028
==========

[commit-bot: I haz the power, 2015-12-16 14:24:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-16 14:24:15]

Description was changed from

==========
AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028
==========

to

==========
AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

All encoders already handle the "Opus-specific" requests sanely (by
failing nicely), so we don't need extra checks to protect them.

BUG=webrtc:5028

Committed: https://crrev.com/44307630d3ad6dcdd7b7fd07e78881b50a92ced4
Cr-Commit-Position: refs/heads/master@{#11051}
==========

[commit-bot: I haz the power, 2015-12-16 14:24:16]

Patchset 3 (id:??) landed as
https://crrev.com/44307630d3ad6dcdd7b7fd07e78881b50a92ced4
Cr-Commit-Position: refs/heads/master@{#11051}