webrtc/modules/audio_coding/test/TestVADDTX.cc - Issue 1527453005: AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/test/TestVADDTX.cc

Issue 1527453005: AudioCodingModuleImpl: Stop failing artificially for non-Opus encoders (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@rac1

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/acm2/codec_manager.cc ('k') | webrtc/voice_engine/test/auto_test/standard/codec_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/test/TestVADDTX.cc

diff --git a/webrtc/modules/audio_coding/test/TestVADDTX.cc b/webrtc/modules/audio_coding/test/TestVADDTX.cc

index a7d2c2134b59edeac0a725780f812e7268305439..229dc2d4745291d84349024081c87cea727d82a0 100644

--- a/webrtc/modules/audio_coding/test/TestVADDTX.cc

+++ b/webrtc/modules/audio_coding/test/TestVADDTX.cc

@@ -234,10 +234,10 @@ void TestWebRtcVadDtx::SetVAD(bool enable_dtx, bool enable_vad,

// Following is the implementation of TestOpusDtx.

void TestOpusDtx::Perform() {

#ifdef WEBRTC_CODEC_ISAC

- // If we set other codec than Opus, DTX cannot be toggled.

+ // If we set other codec than Opus, DTX cannot be switched on.

RegisterCodec(kIsacWb);

EXPECT_EQ(-1, acm_send_->EnableOpusDtx());

- EXPECT_EQ(-1, acm_send_->DisableOpusDtx());

+ EXPECT_EQ(0, acm_send_->DisableOpusDtx());

#endif

#ifdef WEBRTC_CODEC_OPUS

« no previous file with comments | « webrtc/modules/audio_coding/acm2/codec_manager.cc ('k') | webrtc/voice_engine/test/auto_test/standard/codec_test.cc » ('j') | no next file with comments »