Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1524993002: Base webrtc fuzzers on a template. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Base webrtc fuzzers on a template. Removes noisy dependencies on webrtc_fuzzer_main and removal of find_bad_constructs, removes 1-6 lines of gn per fuzzer target. BUG=webrtc:4771 R=kjellander@webrtc.org Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f Cr-Commit-Position: refs/heads/master@{#11022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 6 chunks +8 lines, -31 lines 0 comments Download
A webrtc/test/fuzzers/webrtc_fuzzer.gni View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
PTAL, I think you'll pref this over the repeated find_bad_constructs removal.
5 years ago (2015-12-14 23:07:13 UTC) #1
kjellander_webrtc
nice, lgtm! But the root cause should really be fixed.
5 years ago (2015-12-15 07:08:27 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f Cr-Commit-Position: refs/heads/master@{#11022}
5 years ago (2015-12-15 09:46:34 UTC) #5
pbos-webrtc
Committed patchset #1 (id:1) manually as 5ea3da2cbbb0710f9617fb0627c0c4258437b09f (presubmit successful).
5 years ago (2015-12-15 09:46:34 UTC) #6
tommi
5 years ago (2015-12-15 18:23:42 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1528043002/ by tommi@webrtc.org.

The reason for reverting is: Suspect this is breaking the build:
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux....

Powered by Google App Engine
This is Rietveld 408576698