Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1523603002: Address comments from code review 1505253004 (Closed)

Created:
5 years ago by tommi
Modified:
5 years ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Address comments from code review 1505253004 (https://codereview.webrtc.org/1505253004/) BUG= Committed: https://crrev.com/1d5c19d23eb0d0007efd1e80f60f5409c4b25e25 Cr-Commit-Position: refs/heads/master@{#11002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M talk/media/base/mediachannel.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
tommi
5 years ago (2015-12-13 19:46:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523603002/1
5 years ago (2015-12-13 19:47:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-13 20:49:13 UTC) #7
perkj_webrtc
lgtm
5 years ago (2015-12-14 06:53:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523603002/1
5 years ago (2015-12-14 06:53:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 06:54:33 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-14 06:54:44 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d5c19d23eb0d0007efd1e80f60f5409c4b25e25
Cr-Commit-Position: refs/heads/master@{#11002}

Powered by Google App Engine
This is Rietveld 408576698