Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years ago by tommi Modified:
5 years ago Reviewers:
perkj_webrtc CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAddress comments from code review 1505253004
(https://codereview.webrtc.org/1505253004/)
BUG=
Committed: https://crrev.com/1d5c19d23eb0d0007efd1e80f60f5409c4b25e25
Cr-Commit-Position: refs/heads/master@{#11002}
Patch Set 1 #
Created: 5 years ago
Messages
Total messages: 14 (7 generated)
tommi@webrtc.org changed reviewers: + perkj@webrtc.org
Description was changed from ========== Address comments from code review 1505253004 BUG= ========== to ========== Address comments from code review 1505253004 (https://codereview.webrtc.org/1505253004/) BUG= ==========
The CQ bit was checked by tommi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by perkj@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523603002/1
Message was sent while issue was closed.
Description was changed from ========== Address comments from code review 1505253004 (https://codereview.webrtc.org/1505253004/) BUG= ========== to ========== Address comments from code review 1505253004 (https://codereview.webrtc.org/1505253004/) BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Address comments from code review 1505253004 (https://codereview.webrtc.org/1505253004/) BUG= ========== to ========== Address comments from code review 1505253004 (https://codereview.webrtc.org/1505253004/) BUG= Committed: https://crrev.com/1d5c19d23eb0d0007efd1e80f60f5409c4b25e25 Cr-Commit-Position: refs/heads/master@{#11002} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1d5c19d23eb0d0007efd1e80f60f5409c4b25e25 Cr-Commit-Position: refs/heads/master@{#11002} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
