Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: talk/media/base/mediachannel.h

Issue 1523603002: Address comments from code review 1505253004 (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 13 matching lines...) Expand all
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #ifndef TALK_MEDIA_BASE_MEDIACHANNEL_H_ 28 #ifndef TALK_MEDIA_BASE_MEDIACHANNEL_H_
29 #define TALK_MEDIA_BASE_MEDIACHANNEL_H_ 29 #define TALK_MEDIA_BASE_MEDIACHANNEL_H_
30 30
31 #include <string> 31 #include <string>
32 #include <vector> 32 #include <vector>
33 33
34 #include "talk/media/base/audiorenderer.h"
35 #include "talk/media/base/codec.h" 34 #include "talk/media/base/codec.h"
36 #include "talk/media/base/constants.h" 35 #include "talk/media/base/constants.h"
37 #include "talk/media/base/streamparams.h" 36 #include "talk/media/base/streamparams.h"
38 #include "webrtc/base/basictypes.h" 37 #include "webrtc/base/basictypes.h"
39 #include "webrtc/base/buffer.h" 38 #include "webrtc/base/buffer.h"
40 #include "webrtc/base/dscp.h" 39 #include "webrtc/base/dscp.h"
41 #include "webrtc/base/logging.h" 40 #include "webrtc/base/logging.h"
42 #include "webrtc/base/optional.h" 41 #include "webrtc/base/optional.h"
43 #include "webrtc/base/sigslot.h" 42 #include "webrtc/base/sigslot.h"
44 #include "webrtc/base/socket.h" 43 #include "webrtc/base/socket.h"
45 #include "webrtc/base/window.h" 44 #include "webrtc/base/window.h"
46 // TODO(juberti): re-evaluate this include 45 // TODO(juberti): re-evaluate this include
47 #include "talk/session/media/audiomonitor.h" 46 #include "talk/session/media/audiomonitor.h"
48 47
49 namespace rtc { 48 namespace rtc {
50 class Buffer; 49 class Buffer;
51 class RateLimiter; 50 class RateLimiter;
52 class Timing; 51 class Timing;
53 } 52 }
54 53
55 namespace webrtc { 54 namespace webrtc {
56 class AudioSinkInterface; 55 class AudioSinkInterface;
57 } 56 }
58 57
59 namespace cricket { 58 namespace cricket {
60 59
61 struct RtpHeader; 60 class AudioRenderer;
62 class ScreencastId; 61 class ScreencastId;
63 struct VideoFormat;
64 class VideoCapturer; 62 class VideoCapturer;
65 class VideoRenderer; 63 class VideoRenderer;
64 struct RtpHeader;
65 struct VideoFormat;
66 66
67 const int kMinRtpHeaderExtensionId = 1; 67 const int kMinRtpHeaderExtensionId = 1;
68 const int kMaxRtpHeaderExtensionId = 255; 68 const int kMaxRtpHeaderExtensionId = 255;
69 const int kScreencastDefaultFps = 5; 69 const int kScreencastDefaultFps = 5;
70 70
71 template <class T> 71 template <class T>
72 static std::string ToStringIfSet(const char* key, const rtc::Optional<T>& val) { 72 static std::string ToStringIfSet(const char* key, const rtc::Optional<T>& val) {
73 std::string str; 73 std::string str;
74 if (val) { 74 if (val) {
75 str = key; 75 str = key;
(...skipping 1140 matching lines...) Expand 10 before | Expand all | Expand 10 after
1216 // Signal when the media channel is ready to send the stream. Arguments are: 1216 // Signal when the media channel is ready to send the stream. Arguments are:
1217 // writable(bool) 1217 // writable(bool)
1218 sigslot::signal1<bool> SignalReadyToSend; 1218 sigslot::signal1<bool> SignalReadyToSend;
1219 // Signal for notifying that the remote side has closed the DataChannel. 1219 // Signal for notifying that the remote side has closed the DataChannel.
1220 sigslot::signal1<uint32_t> SignalStreamClosedRemotely; 1220 sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
1221 }; 1221 };
1222 1222
1223 } // namespace cricket 1223 } // namespace cricket
1224 1224
1225 #endif // TALK_MEDIA_BASE_MEDIACHANNEL_H_ 1225 #endif // TALK_MEDIA_BASE_MEDIACHANNEL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698