Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1522003005: Reland of Base webrtc fuzzers on a template. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1528043002/ ) Reason for revert: Found missing public_configs that broke Chromium libfuzzer build. Original issue's description: > Revert of Base webrtc fuzzers on a template. (patchset #1 id:1 of https://codereview.webrtc.org/1524993002/ ) > > Reason for revert: > Suspect this is breaking the build: > https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux/builds/1576/steps/compile/logs/stdio > > Original issue's description: > > Base webrtc fuzzers on a template. > > > > Removes noisy dependencies on webrtc_fuzzer_main and removal of > > find_bad_constructs, removes 1-6 lines of gn per fuzzer target. > > > > BUG=webrtc:4771 > > R=kjellander@webrtc.org > > > > Committed: https://crrev.com/5ea3da2cbbb0710f9617fb0627c0c4258437b09f > > Cr-Commit-Position: refs/heads/master@{#11022} > > TBR=kjellander@webrtc.org,pbos@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4771 > > Committed: https://crrev.com/5e0218c66e0686dd00719f1e53f844efa94c9f42 > Cr-Commit-Position: refs/heads/master@{#11032} TBR=kjellander@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4771 Committed: https://crrev.com/78315b9813382a98b85294b097aa6a690743abaf Cr-Commit-Position: refs/heads/master@{#11035}

Patch Set 1 #

Patch Set 2 : missing public_configs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 1 5 chunks +9 lines, -31 lines 1 comment Download
A webrtc/test/fuzzers/webrtc_fuzzer.gni View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
Created Reland of Base webrtc fuzzers on a template.
5 years ago (2015-12-15 20:54:11 UTC) #1
pbos-webrtc
missing public_configs
5 years ago (2015-12-15 20:56:18 UTC) #2
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/78315b9813382a98b85294b097aa6a690743abaf Cr-Commit-Position: refs/heads/master@{#11035}
5 years ago (2015-12-15 20:58:05 UTC) #5
pbos-webrtc
Committed patchset #2 (id:70001) manually as 78315b9813382a98b85294b097aa6a690743abaf (presubmit successful).
5 years ago (2015-12-15 20:58:05 UTC) #6
kjellander_webrtc
5 years ago (2015-12-15 21:48:04 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.webrtc.org/1522003005/diff/70001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1522003005/diff/70001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:52: public_configs = [
"../..:common_inherited_config" ]
Things like this keeps biting us. It will be nice when we can clean this up when
GYP is removed.

Powered by Google App Engine
This is Rietveld 408576698