Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1520893002:
GN: Mark dl sourceset as non-chromium code to silence compiler warnings (Closed)
DescriptionGN: Mark dl sourceset as non-chromium code to silence compiler warnings
Warnings show when target_cpu="arm64"
BUG=568883
NOTRY=true
NOPRESUBMIT=true
R=rtoy@google.com
Committed: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax/+/ff8766d39ce6b9c1c59fd6b752833e138852e778
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
Description was changed from ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings BUG=568883 ========== to ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings BUG=568883 ==========
agrieve@chromium.org changed reviewers: + rtoy@google.com
On 2015/12/11 13:34:36, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:rtoy@google.com ◐ o ◑
Description was changed from ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings BUG=568883 ========== to ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings Warnings show when target_cpu="arm64" BUG=568883 ==========
agrieve@chromium.org changed reviewers: + ajm@google.com, kma@google.com
On 2015/12/11 13:34:44, agrieve wrote: > On 2015/12/11 13:34:36, agrieve wrote: > > mailto:agrieve@chromium.org changed reviewers: > > + mailto:rtoy@google.com > > ◐ o ◑ broadening reviewers
So sorry for the delay! lgtm
On 2015/12/16 15:40:04, Raymond Toy (Google) wrote: > So sorry for the delay! > > lgtm No problem, thanks!
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520893002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings Warnings show when target_cpu="arm64" BUG=568883 ========== to ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings Warnings show when target_cpu="arm64" BUG=568883 NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520893002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for dl/BUILD.gn:
While running git apply --index -3 -p1;
Created missing directory dl.
error: dl/BUILD.gn: does not exist in index
Patch: dl/BUILD.gn
Index: dl/BUILD.gn
diff --git a/dl/BUILD.gn b/dl/BUILD.gn
index
5459f48c109f22a944927888c184811b643919f8..c5b6d36ac7bc2228aaa67206f172aa6dbc1b4373
100644
--- a/dl/BUILD.gn
+++ b/dl/BUILD.gn
@@ -40,6 +40,8 @@ config("dl_config") {
# GYP: third_party/openmax_dl/dl/dl.gyp:openmax_dl
source_set("dl") {
public_configs = [ ":dl_config" ]
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
sources = [
"api/omxtypes.h",
"sp/api/omxSP.h",
The CQ bit was unchecked by commit-bot@chromium.org
Hmm, any tips for how to land this? "git cl land" also failed (even after rebasing): Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit commit checks ... Presubmit checks passed. Description: GN: Mark dl sourceset as non-chromium code to silence compiler warnings Warnings show when target_cpu="arm64" BUG=568883 NOTRY=true NOPRESUBMIT=true R=rtoy@google.com Review URL: https://codereview.webrtc.org/1520893002 . dl/BUILD.gn | 2 ++ 1 file changed, 2 insertions(+) Counting objects: 4, done. Delta compression using up to 40 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 639 bytes | 0 bytes/s, done. Total 4 (delta 2), reused 1 (delta 0) remote: Resolving deltas: 100% (2/2) remote: Processing changes: refs: 1, done error: failed to push some refs to 'https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git' Failed to push. If this persists, please file a bug.
On 2015/12/16 16:51:27, agrieve wrote: > Hmm, any tips for how to land this? "git cl land" also failed (even after > rebasing): > > Using 50% similarity for rename/copy detection. Override with --similarity. > Running presubmit commit checks ... > > Presubmit checks passed. > Description: > GN: Mark dl sourceset as non-chromium code to silence compiler warnings > > Warnings show when target_cpu="arm64" > > BUG=568883 > NOTRY=true > NOPRESUBMIT=true > mailto:R=rtoy@google.com > > Review URL: https://codereview.webrtc.org/1520893002 . > dl/BUILD.gn | 2 ++ > 1 file changed, 2 insertions(+) > Counting objects: 4, done. > Delta compression using up to 40 threads. > Compressing objects: 100% (4/4), done. > Writing objects: 100% (4/4), 639 bytes | 0 bytes/s, done. > Total 4 (delta 2), reused 1 (delta 0) > remote: Resolving deltas: 100% (2/2) > remote: Processing changes: refs: 1, done > error: failed to push some refs to > 'https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git' > Failed to push. If this persists, please file a bug. Asked chromium-dev, and the answer is simply that someone with committer rights for webrtc needs to land (duh).
On 2015/12/16 19:12:05, agrieve wrote: > On 2015/12/16 16:51:27, agrieve wrote: > > Hmm, any tips for how to land this? "git cl land" also failed (even after > > rebasing): > > > > Using 50% similarity for rename/copy detection. Override with --similarity. > > Running presubmit commit checks ... > > > > Presubmit checks passed. > > Description: > > GN: Mark dl sourceset as non-chromium code to silence compiler warnings > > > > Warnings show when target_cpu="arm64" > > > > BUG=568883 > > NOTRY=true > > NOPRESUBMIT=true > > mailto:R=rtoy@google.com > > > > Review URL: https://codereview.webrtc.org/1520893002 . > > dl/BUILD.gn | 2 ++ > > 1 file changed, 2 insertions(+) > > Counting objects: 4, done. > > Delta compression using up to 40 threads. > > Compressing objects: 100% (4/4), done. > > Writing objects: 100% (4/4), 639 bytes | 0 bytes/s, done. > > Total 4 (delta 2), reused 1 (delta 0) > > remote: Resolving deltas: 100% (2/2) > > remote: Processing changes: refs: 1, done > > error: failed to push some refs to > > > 'https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git' > > Failed to push. If this persists, please file a bug. > > Asked chromium-dev, and the answer is simply that someone with committer rights > for webrtc needs to land (duh). Yeah, webrtc doesn't have a commit queue. I'll land this for you shortly.
Description was changed from ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings Warnings show when target_cpu="arm64" BUG=568883 NOTRY=true NOPRESUBMIT=true ========== to ========== GN: Mark dl sourceset as non-chromium code to silence compiler warnings Warnings show when target_cpu="arm64" BUG=568883 NOTRY=true NOPRESUBMIT=true R=rtoy@google.com Committed: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax/+/... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as ff8766d39ce6b9c1c59fd6b752833e138852e778 (presubmit successful).
Message was sent while issue was closed.
Don't forget to update chromium DEPS to get this change to propagate. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
