Chromium Code Reviews

Issue 1520513003: Fixed lint warnings in webrtc/modules/remote_bitrate_estimator (Closed)

Created:
5 years ago by terelius
Modified:
5 years ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simple CL to fix lint errors in webrtc/modules/remote_bitrate_estimator. Added the lint check for the folder to the presubmit script. BUG=webrtc:5310 Committed: https://crrev.com/8f09f170e650e14c4cd57c51be32a46e8cd1843b Cr-Commit-Position: refs/heads/master@{#11021}

Patch Set 1 #

Patch Set 2 : Fixed presubmit script and remaing lint errors. #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Comments from Stefan #

Total comments: 1

Patch Set 5 : Change POD class to struct #

Total comments: 2

Patch Set 6 : Include in alphabetic order #

Unified diffs Side-by-side diffs Stats (+117 lines, -109 lines)
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h View 1 chunk +1 line, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 4 chunks +9 lines, -10 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc View 4 chunks +2 lines, -4 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h View 1 chunk +22 lines, -35 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_observer.h View 2 chunks +3 lines, -3 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 2 chunks +3 lines, -3 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/inter_arrival.cc View 1 chunk +1 line, -2 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/overuse_detector.cc View 1 chunk +4 lines, -2 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc View 1 chunk +2 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +2 lines, -0 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 2 chunks +16 lines, -13 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream_unittest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.h View 1 chunk +1 line, -0 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 4 chunks +12 lines, -9 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc View 8 chunks +19 lines, -15 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/test/bwe.h View 1 chunk +3 lines, -0 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h View 3 chunks +4 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc View 3 chunks +3 lines, -4 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc View 1 chunk +2 lines, -2 lines 0 comments
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 2 chunks +2 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 21 (8 generated)
terelius
Stefan, could you review the fixes to the lint warnings in remote_bitrate_estimator? Magnus, can you ...
5 years ago (2015-12-11 10:43:03 UTC) #3
stefan-webrtc
LG make sure this builds with ./webrtc/build/gyp_webrtc -Denable_bwe_test_logging=1 https://codereview.webrtc.org/1520513003/diff/40001/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h File webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h (right): https://codereview.webrtc.org/1520513003/diff/40001/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h#newcode52 webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h:52: double ...
5 years ago (2015-12-11 11:08:50 UTC) #4
terelius
On 2015/12/11 11:08:50, stefan-webrtc (holmer) wrote: > LG > > make sure this builds with ...
5 years ago (2015-12-11 13:04:26 UTC) #5
terelius
https://codereview.webrtc.org/1520513003/diff/40001/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h File webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h (right): https://codereview.webrtc.org/1520513003/diff/40001/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h#newcode52 webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h:52: double _noiseVar; On 2015/12/11 11:08:50, stefan-webrtc (holmer) wrote: > ...
5 years ago (2015-12-11 13:06:09 UTC) #6
stefan-webrtc
lgtm, but please consider fixing my remaining request. https://codereview.webrtc.org/1520513003/diff/60001/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h File webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h (right): https://codereview.webrtc.org/1520513003/diff/60001/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h#newcode44 webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h:44: double ...
5 years ago (2015-12-11 13:07:55 UTC) #7
terelius
On 2015/12/11 13:07:55, stefan-webrtc (holmer) wrote: > lgtm, but please consider fixing my remaining request. ...
5 years ago (2015-12-12 18:39:38 UTC) #8
mflodman
One comment, then LGTM. https://codereview.webrtc.org/1520513003/diff/80001/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h File webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h (right): https://codereview.webrtc.org/1520513003/diff/80001/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h#newcode24 webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h:24: #include <utility> Alphabetic order.
5 years ago (2015-12-14 12:05:36 UTC) #9
terelius
https://codereview.webrtc.org/1520513003/diff/80001/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h File webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h (right): https://codereview.webrtc.org/1520513003/diff/80001/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h#newcode24 webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h:24: #include <utility> On 2015/12/14 12:05:36, mflodman wrote: > Alphabetic ...
5 years ago (2015-12-14 15:28:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520513003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520513003/100001
5 years ago (2015-12-14 16:38:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years ago (2015-12-14 17:28:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520513003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520513003/100001
5 years ago (2015-12-15 08:47:57 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-15 08:51:59 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-15 08:52:07 UTC) #21
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/8f09f170e650e14c4cd57c51be32a46e8cd1843b
Cr-Commit-Position: refs/heads/master@{#11021}

Powered by Google App Engine