webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h - Issue 1520513003: Fixed lint warnings in webrtc/modules/remote_bitrate_estimator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

Issue 1520513003: Fixed lint warnings in webrtc/modules/remote_bitrate_estimator (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Include in alphabetic order Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/bwe.h ('k') | webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

index f7c1d1f0bf4db639f02617d53c69c3f62ba64c9f..3bb9b95f4bf458c437940737671f0ea57242da2d 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

@@ -17,8 +17,10 @@

#include <algorithm>

#include <list>

#include <numeric>

+#include <set>

#include <sstream>

#include <string>

+#include <utility>

#include <vector>

#include "webrtc/base/common.h"

@@ -44,7 +46,7 @@ class DelayCapHelper;

class RateCounter {

public:

- RateCounter(int64_t window_size_ms)

+ explicit RateCounter(int64_t window_size_ms)

: window_size_us_(1000 * window_size_ms),

recently_received_packets_(0),

recently_received_bytes_(0),

@@ -415,6 +417,7 @@ class VideoSource {

uint32_t frame_size_bytes_;

private:

+ Random random_;

const int flow_id_;

int64_t next_frame_ms_;

int64_t next_frame_rand_ms_;