Fixing and re-enabling some flaky PeerConnection tests.

Fixing and re-enabling some flaky PeerConnection tests.

BUG=webrtc:3362
Committed: https://crrev.com/c9be00797edf9a12ff88c81bb56194c74dcacf7f
Cr-Commit-Position: refs/heads/master@{#11016}

[Taylor Brandstetter, 2015-12-09 19:57:25]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2015-12-09 19:57:25]

PTAL Peter. I had to rewrite the UpdateOfferWithRejectedContent test somewhat,
and while I was at it, I switched to using a scoped_ptr for FakeVideoRenderers.

[pthatcher1, 2015-12-11 02:10:13]

Impressive work!

https://codereview.webrtc.org/1512763003/diff/1/talk/app/webrtc/peerconnectio...
File talk/app/webrtc/peerconnection_unittest.cc (right):

https://codereview.webrtc.org/1512763003/diff/1/talk/app/webrtc/peerconnectio...
talk/app/webrtc/peerconnection_unittest.cc:450: int TotalAudioFramesReceived()
const {
I'd just call this audio_frames_received()

https://codereview.webrtc.org/1512763003/diff/1/talk/app/webrtc/peerconnectio...
talk/app/webrtc/peerconnection_unittest.cc:482: int TotalVideoFramesReceived()
const {
Likewise, video_frames_received()

[pthatcher1, 2015-12-11 02:10:19]

lgtm

[Taylor Brandstetter, 2015-12-14 20:06:10]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2015-12-14 20:06:11]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1512763003/#ps20001 (title:
"Renaming methods as suggested.")

[commit-bot: I haz the power, 2015-12-14 20:06:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512763003/20001

[commit-bot: I haz the power, 2015-12-14 22:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-14 22:06:57]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Taylor Brandstetter, 2015-12-15 02:14:19]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2015-12-15 02:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512763003/20001

[commit-bot: I haz the power, 2015-12-15 02:28:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 02:28:08]

Description was changed from

==========
Fixing and re-enabling some flaky PeerConnection tests.

BUG=webrtc:3362
==========

to

==========
Fixing and re-enabling some flaky PeerConnection tests.

BUG=webrtc:3362

Committed: https://crrev.com/c9be00797edf9a12ff88c81bb56194c74dcacf7f
Cr-Commit-Position: refs/heads/master@{#11016}
==========

[commit-bot: I haz the power, 2015-12-15 02:28:09]

Patchset 2 (id:??) landed as
https://crrev.com/c9be00797edf9a12ff88c81bb56194c74dcacf7f
Cr-Commit-Position: refs/heads/master@{#11016}