talk/app/webrtc/peerconnectionendtoend_unittest.cc - Issue 1512763003: Fixing and re-enabling some flaky PeerConnection tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectionendtoend_unittest.cc

Issue 1512763003: Fixing and re-enabling some flaky PeerConnection tests. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Renaming methods as suggested. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/peerconnectionendtoend_unittest.cc

diff --git a/talk/app/webrtc/peerconnectionendtoend_unittest.cc b/talk/app/webrtc/peerconnectionendtoend_unittest.cc

index 1d7bb9211eb098f26dd819c6d28eaa7b7337ebf7..6e506345ba260190ad6ca81401356508690285d9 100644

--- a/talk/app/webrtc/peerconnectionendtoend_unittest.cc

+++ b/talk/app/webrtc/peerconnectionendtoend_unittest.cc

@@ -230,8 +230,7 @@ TEST_F(PeerConnectionEndToEndTest, Call) {

}

#endif // if !defined(THREAD_SANITIZER) && !defined(WEBRTC_MAC)

-// Disabled per b/14899892

-TEST_F(PeerConnectionEndToEndTest, DISABLED_CallWithLegacySdp) {

+TEST_F(PeerConnectionEndToEndTest, CallWithLegacySdp) {

FakeConstraints pc_constraints;

pc_constraints.AddMandatory(MediaConstraintsInterface::kEnableDtlsSrtp,

false);

« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | no next file » | no next file with comments »