Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1509463002: Roll gtest-parallel. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll gtest-parallel. Brings in fixes that save log output to disk instead of piping them through Python. Should fix problem where output from tests stall for more than 10 seconds. Also enabling JsepPeerConnectionP2PTestClient on all platforms again. BUG=webrtc:5231 R=kjellander@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/cf890bc58eb28d5f1f6ce3f90d4e541983042369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -64 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 33 chunks +35 lines, -43 lines 0 comments Download
M third_party/gtest-parallel/README.webrtc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/gtest-parallel/gtest-parallel View 8 chunks +39 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pbos-webrtc
PTAL
5 years ago (2015-12-07 14:02:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509463002/1
5 years ago (2015-12-07 15:03:08 UTC) #3
kjellander_webrtc
lgtm, feel free to skip the armt64 bot, it's queued up pretty bad today. Can ...
5 years ago (2015-12-07 15:40:17 UTC) #4
kjellander_webrtc
On 2015/12/07 15:40:17, kjellander (webrtc) wrote: > lgtm, feel free to skip the armt64 bot, ...
5 years ago (2015-12-07 15:40:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf890bc58eb28d5f1f6ce3f90d4e541983042369 Cr-Commit-Position: refs/heads/master@{#10917}
5 years ago (2015-12-07 15:45:14 UTC) #8
pbos-webrtc
Committed patchset #1 (id:1) manually as cf890bc58eb28d5f1f6ce3f90d4e541983042369 (presubmit successful).
5 years ago (2015-12-07 15:45:14 UTC) #9
kjellander_webrtc
5 years ago (2015-12-07 16:22:43 UTC) #10
Message was sent while issue was closed.
On 2015/12/07 15:45:14, pbos-webrtc wrote:
> Committed patchset #1 (id:1) manually as
> cf890bc58eb28d5f1f6ce3f90d4e541983042369 (presubmit successful).

For the record, this is essentially reverting
https://codereview.webrtc.org/1462933002

Powered by Google App Engine
This is Rietveld 408576698