Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462933002: Disable all JsepPeerConnectionP2PTestClient tests on Mac due to flakiness on Mac Debug bots. (Closed)

Created:
5 years, 1 month ago by ivoc
Modified:
5 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable all JsepPeerConnectionP2PTestClient tests on Mac due to flakiness on Mac Debug bots. NOTRY=true TBR=kjellander@webrtc.org BUG=webrtc:5231 Committed: https://crrev.com/191c1f9d5bc1a4adbcaf87fe93214c54b3530dc8 Cr-Commit-Position: refs/heads/master@{#10716}

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -81 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 30 chunks +43 lines, -81 lines 7 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462933002/1
5 years, 1 month ago (2015-11-19 15:50:22 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-19 17:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462933002/1
5 years, 1 month ago (2015-11-19 19:08:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 19:12:09 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/191c1f9d5bc1a4adbcaf87fe93214c54b3530dc8 Cr-Commit-Position: refs/heads/master@{#10716}
5 years, 1 month ago (2015-11-19 19:12:21 UTC) #10
kjellander_webrtc
Please make sure you publish+mail comments for CLs like this, as I didn't get any ...
5 years ago (2015-12-02 12:16:38 UTC) #12
ivoc
On 2015/12/02 12:16:38, kjellander (webrtc) wrote: > Please make sure you publish+mail comments for CLs ...
5 years ago (2015-12-03 09:53:17 UTC) #13
kjellander_webrtc
5 years ago (2015-12-03 09:56:01 UTC) #14
Message was sent while issue was closed. 
On 2015/12/03 09:53:17, ivoc wrote:
> On 2015/12/02 12:16:38, kjellander (webrtc) wrote:
> > Please make sure you publish+mail comments for CLs like this, as I didn't
get
> > any e-mail for this review (the commit-bot messages didn't produce e-mails
to
> me
> > since I wasn't on the reviewers list).
> > 
> > Also a follow-up CL is needed, see comments below.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > File talk/app/webrtc/peerconnection_unittest.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1174:
> > MAYBE_LocalP2PTestOfferDtlsButNotSdes) {
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1254:
> > TEST_F(MAYBE_JsepPeerConnectionP2PTestClient,
MAYBE_GetAudioOutputLevelStats)
> {
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1273:
> > TEST_F(MAYBE_JsepPeerConnectionP2PTestClient, MAYBE_GetAudioInputLevelStats)
{
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1284:
> > TEST_F(MAYBE_JsepPeerConnectionP2PTestClient, MAYBE_GetBytesReceivedStats) {
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1306:
> > TEST_F(MAYBE_JsepPeerConnectionP2PTestClient, MAYBE_GetBytesSentStats) {
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1359:
> > TEST_F(MAYBE_JsepPeerConnectionP2PTestClient, MAYBE_GetDtls12Both) {
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> > 
> >
>
https://codereview.webrtc.org/1462933002/diff/1/talk/app/webrtc/peerconnectio...
> > talk/app/webrtc/peerconnection_unittest.cc:1575:
> > TEST_F(MAYBE_JsepPeerConnectionP2PTestClient, MAYBE_IceRestart) {
> > Please remove MAYBE_ from the test case name in a follow-up CL.
> 
> Sorry about that, I didn't realise you would not receive any mails. I did TBR
> you on a few other CLs as well while I was sheriffing (to disable other flaky
> tests). I will submit the follow-up CL right away.

No worries. I also thought at least one e-mail was sent when you TBR= someone
and submit from command line.
Can you find the other CLs and publish comments for them as well, so I don't
have to dig them up myself?

Powered by Google App Engine
This is Rietveld 408576698