Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1507723002: PRESUBMIT: change native API check from warning to information. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PRESUBMIT: change native API check from warning to information. NOTRY=True Committed: https://crrev.com/ffea13c42cc3ebc118b6261be688f88974cc7ab5 Cr-Commit-Position: refs/heads/master@{#10931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_webrtc
5 years ago (2015-12-07 17:07:34 UTC) #2
hbos
lgtm
5 years ago (2015-12-08 09:46:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507723002/1
5 years ago (2015-12-08 09:47:08 UTC) #5
kjellander_webrtc
On 2015/12/08 09:47:08, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years ago (2015-12-08 09:48:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507723002/1
5 years ago (2015-12-08 09:49:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 09:57:20 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-08 09:57:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffea13c42cc3ebc118b6261be688f88974cc7ab5
Cr-Commit-Position: refs/heads/master@{#10931}

Powered by Google App Engine
This is Rietveld 408576698