Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: PRESUBMIT.py

Issue 1507723002: PRESUBMIT: change native API check from warning to information. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 def _CheckNativeApiHeaderChanges(input_api, output_api): 76 def _CheckNativeApiHeaderChanges(input_api, output_api):
77 """Checks to remind proper changing of native APIs.""" 77 """Checks to remind proper changing of native APIs."""
78 files = [] 78 files = []
79 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): 79 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
80 if f.LocalPath().endswith('.h'): 80 if f.LocalPath().endswith('.h'):
81 for path in NATIVE_API_DIRS: 81 for path in NATIVE_API_DIRS:
82 if os.path.dirname(f.LocalPath()) == path: 82 if os.path.dirname(f.LocalPath()) == path:
83 files.append(f) 83 files.append(f)
84 84
85 if files: 85 if files:
86 return [output_api.PresubmitPromptWarning( 86 return [output_api.PresubmitNotifyResult(
87 'You seem to be changing native API header files. Please make sure ' 87 'You seem to be changing native API header files. Please make sure '
88 'you:\n' 88 'you:\n'
89 ' 1. Make compatible changes that don\'t break existing clients.\n' 89 ' 1. Make compatible changes that don\'t break existing clients.\n'
90 ' 2. Mark the old APIs as deprecated.\n' 90 ' 2. Mark the old APIs as deprecated.\n'
91 ' 3. Create a timeline and plan for when the deprecated method will ' 91 ' 3. Create a timeline and plan for when the deprecated method will '
92 'be removed (preferably 3 months or so).\n' 92 'be removed (preferably 3 months or so).\n'
93 ' 4. Update/inform existing downstream code owners to stop using the ' 93 ' 4. Update/inform existing downstream code owners to stop using the '
94 'deprecated APIs: \n' 94 'deprecated APIs: \n'
95 'send announcement to discuss-webrtc@googlegroups.com and ' 95 'send announcement to discuss-webrtc@googlegroups.com and '
96 'webrtc-users@google.com.\n' 96 'webrtc-users@google.com.\n'
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 for builder in masters[master]: 457 for builder in masters[master]:
458 if 'presubmit' in builder: 458 if 'presubmit' in builder:
459 # Do not trigger presubmit builders, since they're likely to fail 459 # Do not trigger presubmit builders, since they're likely to fail
460 # (e.g. OWNERS checks before finished code review), and we're running 460 # (e.g. OWNERS checks before finished code review), and we're running
461 # local presubmit anyway. 461 # local presubmit anyway.
462 pass 462 pass
463 else: 463 else:
464 try_config[master][builder] = ['defaulttests'] 464 try_config[master][builder] = ['defaulttests']
465 465
466 return try_config 466 return try_config
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698