Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1506883005: Revert of RTCCertificate::Expires() and ::HasExpired() implemented (Closed)

Created:
5 years ago by hbos
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of RTCCertificate::Expires() and ::HasExpired() implemented (patchset #5 id:140001 of https://codereview.webrtc.org/1494103003/ ) Reason for revert: RTCCertificate's expires_timestamp_ns was renamed to Expires but the old function is still used in one place in Chromium... https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Mac%20Builder/builds/7405 Original issue's description: > RTCCertificate::Expires() and ::HasExpired() implemented using SSLCertificate::CertificateExpirationTime(). > > NOPRESUBMIT=true > BUG=chromium:544894 > > Committed: https://crrev.com/20ef654174e245b3a06c9e9045bb97be9acd90cf > Cr-Commit-Position: refs/heads/master@{#10930} TBR=torbjorng@webrtc.org,hta@webrtc.org,kjellander@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:544894 Committed: https://crrev.com/cd6f539a083f1c5ac4a548b73c03c444a813528d Cr-Commit-Position: refs/heads/master@{#10933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -144 lines) Patch
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/fakesslidentity.h View 3 chunks +3 lines, -12 lines 0 comments Download
M webrtc/base/rtccertificate.h View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/base/rtccertificate.cc View 2 chunks +6 lines, -8 lines 0 comments Download
D webrtc/base/rtccertificate_unittests.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M webrtc/base/sslidentity.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hbos
Created Revert of RTCCertificate::Expires() and ::HasExpired() implemented
5 years ago (2015-12-08 10:31:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506883005/1
5 years ago (2015-12-08 10:32:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 10:32:20 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-08 10:32:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd6f539a083f1c5ac4a548b73c03c444a813528d
Cr-Commit-Position: refs/heads/master@{#10933}

Powered by Google App Engine
This is Rietveld 408576698