Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: webrtc/base/rtccertificate.cc

Issue 1506883005: Revert of RTCCertificate::Expires() and ::HasExpired() implemented (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/rtccertificate.h ('k') | webrtc/base/rtccertificate_unittests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/rtccertificate.h" 11 #include "webrtc/base/rtccertificate.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 #include "webrtc/base/timeutils.h"
14 15
15 namespace rtc { 16 namespace rtc {
16 17
17 scoped_refptr<RTCCertificate> RTCCertificate::Create( 18 scoped_refptr<RTCCertificate> RTCCertificate::Create(
18 scoped_ptr<SSLIdentity> identity) { 19 scoped_ptr<SSLIdentity> identity) {
19 return new RefCountedObject<RTCCertificate>(identity.release()); 20 return new RefCountedObject<RTCCertificate>(identity.release());
20 } 21 }
21 22
22 RTCCertificate::RTCCertificate(SSLIdentity* identity) 23 RTCCertificate::RTCCertificate(SSLIdentity* identity)
23 : identity_(identity) { 24 : identity_(identity) {
24 RTC_DCHECK(identity_); 25 RTC_DCHECK(identity_);
25 } 26 }
26 27
27 RTCCertificate::~RTCCertificate() { 28 RTCCertificate::~RTCCertificate() {
28 } 29 }
29 30
30 uint64_t RTCCertificate::Expires() const { 31 uint64_t RTCCertificate::expires_timestamp_ns() const {
31 int64_t expires = ssl_certificate().CertificateExpirationTime(); 32 // TODO(hbos): Update once SSLIdentity/SSLCertificate supports expires field.
32 if (expires != -1) 33 return 0;
33 return static_cast<uint64_t>(expires) * kNumMillisecsPerSec;
34 // If the expiration time could not be retrieved return an expired timestamp.
35 return 0; // = 1970-01-01
36 } 34 }
37 35
38 bool RTCCertificate::HasExpired(uint64_t now) const { 36 bool RTCCertificate::HasExpired() const {
39 return Expires() <= now; 37 return expires_timestamp_ns() <= TimeNanos();
40 } 38 }
41 39
42 const SSLCertificate& RTCCertificate::ssl_certificate() const { 40 const SSLCertificate& RTCCertificate::ssl_certificate() const {
43 return identity_->certificate(); 41 return identity_->certificate();
44 } 42 }
45 43
46 } // namespace rtc 44 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/rtccertificate.h ('k') | webrtc/base/rtccertificate_unittests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698