Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1505573002: Reland Allow remote fingerprint update during a call (Closed)

Created:
5 years ago by guoweis_webrtc
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow remote fingerprint update during a call Changes include the following 1. modify FakeDtlsIdentityStore to support alternate certificate so we could have a different fingerprint in test case. 2. dtlstransportchannel can accept a new fingerprint and trigger DTLS handshake. 3. #2 will trigger new signal on the media side to reset SRTP context. Only reset SRTP context when we are using DTLS (not SDES). 4. Test cases for caller or callee are transfees. TBR=pthatcher@webrtc.org BUG=webrtc:3618 This is a reland of https://codereview.webrtc.org/1453523002 Committed: https://chromium.googlesource.com/external/webrtc/+/1218d7ad2fac035376914bd0649fe99e657b33d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -90 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 9 chunks +111 lines, -20 lines 0 comments Download
M talk/app/webrtc/test/fakedtlsidentitystore.h View 6 chunks +75 lines, -35 lines 0 comments Download
M talk/session/media/channel.h View 2 chunks +3 lines, -0 lines 0 comments Download
M talk/session/media/channel.cc View 12 chunks +60 lines, -24 lines 0 comments Download
M talk/session/media/srtpfilter.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 3 chunks +25 lines, -7 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1218d7ad2fac035376914bd0649fe99e657b33d3 Cr-Commit-Position: refs/heads/master@{#10903}
5 years ago (2015-12-05 18:00:07 UTC) #4
guoweis_webrtc
5 years ago (2015-12-05 18:00:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1218d7ad2fac035376914bd0649fe99e657b33d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698