Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1453523002: Allow remote fingerprint update during a call (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow remote fingerprint update during a call Changes include the following 1. modify FakeDtlsIdentityStore to support alternate certificate so we could have a different fingerprint in test case. 2. dtlstransportchannel can accept a new fingerprint and trigger DTLS handshake. 3. #2 will trigger new signal on the media side to reset SRTP context. Only reset SRTP context when we are using DTLS (not SDES). 4. Test cases for caller or callee are transfees. BUG=webrtc:3618 R=pthatcher@webrtc.org Committed: https://crrev.com/9c38c2d33fa6d794704d53b18f39d5235439fe63 Cr-Commit-Position: refs/heads/master@{#10901}

Patch Set 1 #

Patch Set 2 : #

Total comments: 29

Patch Set 3 : address comments. #

Patch Set 4 : fix rtc_unittests error #

Total comments: 38

Patch Set 5 : #

Patch Set 6 : address comments. #

Total comments: 4

Patch Set 7 : address comments. #

Patch Set 8 : Remove unused code. #

Patch Set 9 : Remove empty line #

Total comments: 11

Patch Set 10 : address juberti comments #

Patch Set 11 : add back the handling of the EOS #

Patch Set 12 : Stop the original client. #

Patch Set 13 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -90 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 9 chunks +111 lines, -20 lines 0 comments Download
M talk/app/webrtc/test/fakedtlsidentitystore.h View 1 2 3 4 6 chunks +75 lines, -35 lines 0 comments Download
M talk/session/media/channel.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -0 lines 0 comments Download
M talk/session/media/channel.cc View 1 2 3 4 5 6 7 8 9 10 11 12 chunks +60 lines, -24 lines 0 comments Download
M talk/session/media/srtpfilter.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 1 2 3 4 5 6 7 8 9 11 3 chunks +25 lines, -7 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 60 (36 generated)
guoweis_webrtc
5 years, 1 month ago (2015-11-16 22:37:05 UTC) #5
guoweis_webrtc
On 2015/11/16 22:37:05, guoweis wrote: Ping
5 years, 1 month ago (2015-11-18 18:06:03 UTC) #6
pthatcher1
https://codereview.webrtc.org/1453523002/diff/20001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/20001/talk/app/webrtc/peerconnection_unittest.cc#newcode662 talk/app/webrtc/peerconnection_unittest.cc:662: use_alternate_key_ = use_alternate_key; Why is this (and use_alternate_key_) static? ...
5 years, 1 month ago (2015-11-18 20:42:43 UTC) #7
guoweis_webrtc
PTAL. https://codereview.webrtc.org/1453523002/diff/20001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/20001/talk/app/webrtc/peerconnection_unittest.cc#newcode662 talk/app/webrtc/peerconnection_unittest.cc:662: use_alternate_key_ = use_alternate_key; On 2015/11/18 20:42:43, pthatcher1 wrote: ...
5 years ago (2015-11-25 21:03:14 UTC) #15
pthatcher1
https://codereview.webrtc.org/1453523002/diff/20001/talk/app/webrtc/test/fakedtlsidentitystore.h File talk/app/webrtc/test/fakedtlsidentitystore.h (right): https://codereview.webrtc.org/1453523002/diff/20001/talk/app/webrtc/test/fakedtlsidentitystore.h#newcode165 talk/app/webrtc/test/fakedtlsidentitystore.h:165: KeyAndCert[key_index_].rsa_private_key_pem, On 2015/11/25 21:03:13, guoweis wrote: > On 2015/11/18 ...
5 years ago (2015-11-30 20:23:11 UTC) #16
guoweis_webrtc
PTAL. https://codereview.webrtc.org/1453523002/diff/200001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/200001/talk/app/webrtc/peerconnection_unittest.cc#newcode151 talk/app/webrtc/peerconnection_unittest.cc:151: bool use_alternate_key) { On 2015/11/30 20:23:10, pthatcher1 wrote: ...
5 years ago (2015-12-01 22:05:13 UTC) #18
pthatcher1
lgtm, with nits https://codereview.webrtc.org/1453523002/diff/200001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/200001/talk/app/webrtc/peerconnection_unittest.cc#newcode1152 talk/app/webrtc/peerconnection_unittest.cc:1152: rtc::scoped_ptr<PeerConnectionTestClient> receiving_client_; On 2015/12/01 22:05:12, guoweis ...
5 years ago (2015-12-01 23:29:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/300001
5 years ago (2015-12-01 23:48:19 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/320001
5 years ago (2015-12-01 23:55:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/320001
5 years ago (2015-12-02 00:21:22 UTC) #29
juberti
https://codereview.webrtc.org/1453523002/diff/320001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/320001/talk/app/webrtc/peerconnection_unittest.cc#newcode152 talk/app/webrtc/peerconnection_unittest.cc:152: bool use_alternate_key) { Instead of using a magic bool ...
5 years ago (2015-12-02 00:29:44 UTC) #31
guoweis_webrtc
https://codereview.webrtc.org/1453523002/diff/320001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/320001/talk/app/webrtc/peerconnection_unittest.cc#newcode152 talk/app/webrtc/peerconnection_unittest.cc:152: bool use_alternate_key) { On 2015/12/02 00:29:43, juberti wrote: > ...
5 years ago (2015-12-02 18:44:16 UTC) #33
guoweis_webrtc
PTAL. https://codereview.webrtc.org/1453523002/diff/320001/talk/app/webrtc/peerconnection_unittest.cc File talk/app/webrtc/peerconnection_unittest.cc (right): https://codereview.webrtc.org/1453523002/diff/320001/talk/app/webrtc/peerconnection_unittest.cc#newcode152 talk/app/webrtc/peerconnection_unittest.cc:152: bool use_alternate_key) { On 2015/12/02 18:44:15, guoweis wrote: ...
5 years ago (2015-12-03 22:59:41 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/380001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/380001
5 years ago (2015-12-04 15:06:43 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: mac_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/10945)
5 years ago (2015-12-04 15:19:26 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/420001
5 years ago (2015-12-04 22:14:06 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/8345)
5 years ago (2015-12-04 22:16:56 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/420001
5 years ago (2015-12-04 22:18:07 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/1638)
5 years ago (2015-12-04 22:19:38 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/8347)
5 years ago (2015-12-04 23:30:41 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453523002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453523002/420001
5 years ago (2015-12-05 05:24:11 UTC) #54
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/5691)
5 years ago (2015-12-05 05:28:05 UTC) #56
guoweis_webrtc
Committed patchset #13 (id:420001) manually as 9c38c2d33fa6d794704d53b18f39d5235439fe63 (presubmit successful).
5 years ago (2015-12-05 17:46:23 UTC) #58
commit-bot: I haz the power
5 years ago (2015-12-05 17:46:24 UTC) #60
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/9c38c2d33fa6d794704d53b18f39d5235439fe63
Cr-Commit-Position: refs/heads/master@{#10901}

Powered by Google App Engine
This is Rietveld 408576698