Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1505053002: Revert of "Create rtc::AtomicInt POD struct." (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, fengyue_agora.io, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, the sun, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of "Create rtc::AtomicInt POD struct." (patchset #3 id:40001 of https://codereview.webrtc.org/1498953002/ ) Reason for revert: Broke downstream compile step, possibly relandable when using a MSVC version that has constexpr, other than that I'm out of ideas. .../webrtc/base/atomicops.h:71:8: note: no known conversion for argument 1 from '<brace-enclosed initializer list>' to 'const rtc::AtomicInt&' Original issue's description: > Reland of "Create rtc::AtomicInt POD struct." > > Relands https://codereview.webrtc.org/1420043008/ with brace initializers > instead of constructors hoping that they won't introduce static > initializers. > > BUG= > R=tommi@webrtc.org > > Committed: https://crrev.com/84f0970d100e67a1dc4fe9a1b16b7d293302044e > Cr-Commit-Position: refs/heads/master@{#10920} TBR=tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/46ad5426b025eddac8e9232014d347e73d27180e Cr-Commit-Position: refs/heads/master@{#10922}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -198 lines) Patch
M talk/session/media/srtpfilter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/atomicops.h View 2 chunks +0 lines, -43 lines 1 comment Download
M webrtc/base/criticalsection.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/criticalsection.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M webrtc/base/refcount.h View 2 chunks +55 lines, -105 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.h View 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 10 chunks +19 lines, -19 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/pacing/packet_router.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/system_wrappers/include/trace.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/system_wrappers/source/trace_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_capture_input.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
Created Revert of "Create rtc::AtomicInt POD struct."
5 years ago (2015-12-07 22:29:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505053002/1
5 years ago (2015-12-07 22:29:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 22:29:18 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/46ad5426b025eddac8e9232014d347e73d27180e Cr-Commit-Position: refs/heads/master@{#10922}
5 years ago (2015-12-07 22:29:30 UTC) #6
pbos-webrtc
5 years ago (2015-12-07 22:33:35 UTC) #7
Message was sent while issue was closed.
This is the final idea I've got, WDYT?

https://codereview.webrtc.org/1505053002/diff/1/webrtc/base/atomicops.h
File webrtc/base/atomicops.h (left):

https://codereview.webrtc.org/1505053002/diff/1/webrtc/base/atomicops.h#oldco...
webrtc/base/atomicops.h:72: AtomicInt() = delete;
Might be relandable without constructors removed (it "should" behave like a
struct for initialization).

Powered by Google App Engine
This is Rietveld 408576698