Reland of "Create rtc::AtomicInt POD struct."

Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/84f0970d100e67a1dc4fe9a1b16b7d293302044e
Cr-Commit-Position: refs/heads/master@{#10920}

[pbos-webrtc, 2015-12-03 21:58:31]

Should we take another stab at this but without the ctors since it was reverted?

[pbos-webrtc, 2015-12-03 21:59:02]

Description was changed from

==========
Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce brace
initializers.

BUG=
R=tommi@webrtc.org
==========

to

==========
Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.

BUG=
R=tommi@webrtc.org
==========

[pbos-webrtc, 2015-12-03 22:00:52]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 22:00:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498953002/20001

[commit-bot: I haz the power, 2015-12-03 22:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 22:03:11]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2154)

[pbos-webrtc, 2015-12-03 22:13:03]

initializer to audio_device_ios.mm

[pbos-webrtc, 2015-12-03 22:14:03]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 22:25:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498953002/40001

[commit-bot: I haz the power, 2015-12-04 00:25:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 00:25:14]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_clang_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_x64_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_x86_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gn_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gn_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  ios32_sim_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  ios64_sim_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  ios_arm64_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  ios_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  ios_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  ios_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_asan on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_compile_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gn_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gn_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_tsan2 on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_asan on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_compile_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_compile_x64_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_x64_gn_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_x64_gn_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_x64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  presubmit on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_compile_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_drmemory_light on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_gn_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_gn_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2015-12-04 14:49:58]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 14:50:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498953002/40001

[commit-bot: I haz the power, 2015-12-04 14:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 14:51:48]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2191)

[tommi, 2015-12-07 20:03:18]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2015-12-07 20:03:19]

lgtm

[commit-bot: I haz the power, 2015-12-07 20:03:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498953002/40001

[commit-bot: I haz the power, 2015-12-07 20:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 20:23:10]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2252)

[pbos-webrtc, 2015-12-07 22:07:16]

Description was changed from

==========
Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.

BUG=
R=tommi@webrtc.org
==========

to

==========
Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/84f0970d100e67a1dc4fe9a1b...
==========

[pbos-webrtc, 2015-12-07 22:07:17]

Committed patchset #3 (id:40001) manually as
84f0970d100e67a1dc4fe9a1b16b7d293302044e (presubmit successful).

[commit-bot: I haz the power, 2015-12-07 22:07:18]

Description was changed from

==========
Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/84f0970d100e67a1dc4fe9a1b...
==========

to

==========
Reland of "Create rtc::AtomicInt POD struct."

Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/84f0970d100e67a1dc4fe9a1b16b7d293302044e
Cr-Commit-Position: refs/heads/master@{#10920}
==========

[commit-bot: I haz the power, 2015-12-07 22:07:19]

Patchset 3 (id:??) landed as
https://crrev.com/84f0970d100e67a1dc4fe9a1b16b7d293302044e
Cr-Commit-Position: refs/heads/master@{#10920}

[pbos-webrtc, 2015-12-07 22:29:02]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1505053002/ by pbos@webrtc.org.

The reason for reverting is: Broke downstream compile step, possibly relandable
when using a MSVC version that has constexpr, other than that I'm out of ideas.

.../webrtc/base/atomicops.h:71:8: note:   no known conversion for argument 1
from '<brace-enclosed initializer list>' to 'const rtc::AtomicInt&'.