Make VoiceDetection not a ProcessingComponent.

Make VoiceDetection not a ProcessingComponent (bit exact).

BUG=webrtc:5354
Committed: https://crrev.com/a29386c26d515be9fbeaeca3e0bc6019f29142c2
Cr-Commit-Position: refs/heads/master@{#11047}

[the sun, 2015-12-10 13:14:31]

Description was changed from

==========
Make VoiceDetection not a ProcessingComponent.

BUG=webrtc:5298
==========

to

==========
Make VoiceDetection not a ProcessingComponent.

BUG=webrtc:5298
==========

[the sun, 2015-12-10 13:14:31]

solenberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, peah@webrtc.org

[the sun, 2015-12-10 13:15:02]

On 2015/12/10 13:14:31, the sun wrote:
> mailto:solenberg@webrtc.org changed reviewers:
> + mailto:henrik.lundin@webrtc.org, mailto:peah@webrtc.org

FYI, I've already started on this component.

[peah-webrtc, 2015-12-11 11:35:54]

Description was changed from

==========
Make VoiceDetection not a ProcessingComponent.

BUG=webrtc:5298
==========

to

==========
Make VoiceDetection not a ProcessingComponent.

BUG=webrtc:5354
==========

[the sun, 2015-12-16 09:26:50]

Description was changed from

==========
Make VoiceDetection not a ProcessingComponent.

BUG=webrtc:5354
==========

to

==========
Make VoiceDetection not a ProcessingComponent (bit exact).

BUG=webrtc:5354
==========

[the sun, 2015-12-16 09:29:29]

Ready for review now.

[peah-webrtc, 2015-12-16 09:50:51]

On 2015/12/16 09:29:29, the sun wrote:
> Ready for review now.

Nice!

lgtm

[hlundin-webrtc, 2015-12-16 10:21:38]

lgtm modulo two nits.

https://codereview.webrtc.org/1494593004/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/voice_detection_impl.cc (right):

https://codereview.webrtc.org/1494593004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/voice_detection_impl.cc:51:
static_cast<size_t>(frame_size_ms_ * sample_rate_hz_) / 1000;
rtc::CheckedDivExact(static_cast<size_t>(frame_size_ms_ * sample_rate_hz_),
1000)

https://codereview.webrtc.org/1494593004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/voice_detection_impl.cc:131:
WebRtcVad_set_mode(vad_->state(), mode);
RTC_DCHECK_EQ(..., 0);

[the sun, 2015-12-16 10:34:27]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-12-16 10:34:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1494593004/#ps80001 (title:
"rebase+comment")

[commit-bot: I haz the power, 2015-12-16 10:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494593004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494593004/80001

[the sun, 2015-12-16 10:36:23]

https://codereview.webrtc.org/1494593004/diff/60001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/voice_detection_impl.cc (right):

https://codereview.webrtc.org/1494593004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/voice_detection_impl.cc:51:
static_cast<size_t>(frame_size_ms_ * sample_rate_hz_) / 1000;
On 2015/12/16 10:21:38, hlundin-webrtc wrote:
> rtc::CheckedDivExact(static_cast<size_t>(frame_size_ms_ * sample_rate_hz_),
> 1000)

I'm trying to not change the behavior here. Maybe we should have some property
on each module to tell the APM what rates they support?

https://codereview.webrtc.org/1494593004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/voice_detection_impl.cc:131:
WebRtcVad_set_mode(vad_->state(), mode);
On 2015/12/16 10:21:38, hlundin-webrtc wrote:
> RTC_DCHECK_EQ(..., 0);

Done.

[commit-bot: I haz the power, 2015-12-16 11:31:16]

Description was changed from

==========
Make VoiceDetection not a ProcessingComponent (bit exact).

BUG=webrtc:5354
==========

to

==========
Make VoiceDetection not a ProcessingComponent (bit exact).

BUG=webrtc:5354
==========

[commit-bot: I haz the power, 2015-12-16 11:31:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-16 11:31:23]

Description was changed from

==========
Make VoiceDetection not a ProcessingComponent (bit exact).

BUG=webrtc:5354
==========

to

==========
Make VoiceDetection not a ProcessingComponent (bit exact).

BUG=webrtc:5354

Committed: https://crrev.com/a29386c26d515be9fbeaeca3e0bc6019f29142c2
Cr-Commit-Position: refs/heads/master@{#11047}
==========

[commit-bot: I haz the power, 2015-12-16 11:31:23]

Patchset 5 (id:??) landed as
https://crrev.com/a29386c26d515be9fbeaeca3e0bc6019f29142c2
Cr-Commit-Position: refs/heads/master@{#11047}