Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: webrtc/modules/audio_processing/voice_detection_impl.h

Issue 1494593004: Make VoiceDetection not a ProcessingComponent. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase+comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_
12 #define WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_ 12 #define WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_
13 13
14 #include "webrtc/base/constructormagic.h"
14 #include "webrtc/base/criticalsection.h" 15 #include "webrtc/base/criticalsection.h"
16 #include "webrtc/base/scoped_ptr.h"
15 #include "webrtc/modules/audio_processing/include/audio_processing.h" 17 #include "webrtc/modules/audio_processing/include/audio_processing.h"
16 #include "webrtc/modules/audio_processing/processing_component.h"
17 18
18 namespace webrtc { 19 namespace webrtc {
19 20
20 class AudioBuffer; 21 class AudioBuffer;
21 22
22 class VoiceDetectionImpl : public VoiceDetection, 23 class VoiceDetectionImpl : public VoiceDetection {
23 public ProcessingComponent {
24 public: 24 public:
25 VoiceDetectionImpl(const AudioProcessing* apm, rtc::CriticalSection* crit); 25 explicit VoiceDetectionImpl(rtc::CriticalSection* crit);
26 virtual ~VoiceDetectionImpl(); 26 ~VoiceDetectionImpl() override;
27 27
28 int ProcessCaptureAudio(AudioBuffer* audio); 28 // TODO(peah): Fold into ctor, once public API is removed.
29 void Initialize(int sample_rate_hz);
30 void ProcessCaptureAudio(AudioBuffer* audio);
29 31
30 // VoiceDetection implementation. 32 // VoiceDetection implementation.
33 int Enable(bool enable) override;
31 bool is_enabled() const override; 34 bool is_enabled() const override;
32
33 // ProcessingComponent implementation.
34 int Initialize() override;
35
36 private:
37 // VoiceDetection implementation.
38 int Enable(bool enable) override;
39 int set_stream_has_voice(bool has_voice) override; 35 int set_stream_has_voice(bool has_voice) override;
40 bool stream_has_voice() const override; 36 bool stream_has_voice() const override;
41 int set_likelihood(Likelihood likelihood) override; 37 int set_likelihood(Likelihood likelihood) override;
42 Likelihood likelihood() const override; 38 Likelihood likelihood() const override;
43 int set_frame_size_ms(int size) override; 39 int set_frame_size_ms(int size) override;
44 int frame_size_ms() const override; 40 int frame_size_ms() const override;
45 41
46 // ProcessingComponent implementation. 42 private:
47 void* CreateHandle() const override; 43 class Vad;
48 int InitializeHandle(void* handle) const override;
49 int ConfigureHandle(void* handle) const override;
50 void DestroyHandle(void* handle) const override;
51 int num_handles_required() const override;
52 int GetHandleError(void* handle) const override;
53
54 // Not guarded as its public API is thread safe.
55 const AudioProcessing* apm_;
56
57 rtc::CriticalSection* const crit_; 44 rtc::CriticalSection* const crit_;
58 45 bool enabled_ GUARDED_BY(crit_) = false;
59 bool stream_has_voice_ GUARDED_BY(crit_); 46 bool stream_has_voice_ GUARDED_BY(crit_) = false;
60 bool using_external_vad_ GUARDED_BY(crit_); 47 bool using_external_vad_ GUARDED_BY(crit_) = false;
61 Likelihood likelihood_ GUARDED_BY(crit_); 48 Likelihood likelihood_ GUARDED_BY(crit_) = kLowLikelihood;
62 int frame_size_ms_ GUARDED_BY(crit_); 49 int frame_size_ms_ GUARDED_BY(crit_) = 10;
63 size_t frame_size_samples_ GUARDED_BY(crit_); 50 size_t frame_size_samples_ GUARDED_BY(crit_) = 0;
51 int sample_rate_hz_ GUARDED_BY(crit_) = 0;
52 rtc::scoped_ptr<Vad> vad_ GUARDED_BY(crit_);
53 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(VoiceDetectionImpl);
64 }; 54 };
65 } // namespace webrtc 55 } // namespace webrtc
66 56
67 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_ 57 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_VOICE_DETECTION_IMPL_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/voice_detection_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698