Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1493933003: Add comments about the Audio parts of the public Call API being WIP. (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add comments about the Audio parts of the public Call API being WIP. BUG=webrtc:4690 R=kjellander@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/a4527c89e77ae6c8c07c935e960bc8d9ddff35b3 Cr-Commit-Position: refs/heads/master@{#10882}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add link to voe refactoring bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/audio_receive_stream.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/audio_send_stream.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/audio_state.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
the sun
5 years ago (2015-12-03 10:18:07 UTC) #2
kjellander_webrtc
lgtm
5 years ago (2015-12-03 10:27:49 UTC) #3
the sun
On 2015/12/03 10:27:49, kjellander (webrtc) wrote: > lgtm +tommi for OWNERs approval
5 years ago (2015-12-03 10:31:53 UTC) #6
tommi
lgtm. if we can include a link to the bug, that would be helpful. https://codereview.webrtc.org/1493933003/diff/1/webrtc/audio_receive_stream.h ...
5 years ago (2015-12-03 11:15:17 UTC) #7
the sun
On 2015/12/03 11:15:17, tommi (webrtc) wrote: > lgtm. if we can include a link to ...
5 years ago (2015-12-03 12:06:03 UTC) #8
the sun
Committed patchset #2 (id:20001) manually as a4527c89e77ae6c8c07c935e960bc8d9ddff35b3 (presubmit successful).
5 years ago (2015-12-03 12:06:37 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 12:06:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4527c89e77ae6c8c07c935e960bc8d9ddff35b3
Cr-Commit-Position: refs/heads/master@{#10882}

Powered by Google App Engine
This is Rietveld 408576698