Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: webrtc/audio_state.h

Issue 1493933003: Add comments about the Audio parts of the public Call API being WIP. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: add link to voe refactoring bug Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio_send_stream.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #ifndef WEBRTC_AUDIO_STATE_H_ 10 #ifndef WEBRTC_AUDIO_STATE_H_
11 #define WEBRTC_AUDIO_STATE_H_ 11 #define WEBRTC_AUDIO_STATE_H_
12 12
13 #include "webrtc/base/refcount.h" 13 #include "webrtc/base/refcount.h"
14 #include "webrtc/base/scoped_ref_ptr.h" 14 #include "webrtc/base/scoped_ref_ptr.h"
15 15
16 namespace webrtc { 16 namespace webrtc {
17 17
18 class AudioDeviceModule; 18 class AudioDeviceModule;
19 class VoiceEngine; 19 class VoiceEngine;
20 20
21 // WORK IN PROGRESS
22 // This class is under development and is not yet intended for for use outside
23 // of WebRtc/Libjingle. Please use the VoiceEngine API instead.
24 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=4690
25
21 // AudioState holds the state which must be shared between multiple instances of 26 // AudioState holds the state which must be shared between multiple instances of
22 // webrtc::Call for audio processing purposes. 27 // webrtc::Call for audio processing purposes.
23 class AudioState : public rtc::RefCountInterface { 28 class AudioState : public rtc::RefCountInterface {
24 public: 29 public:
25 struct Config { 30 struct Config {
26 // VoiceEngine used for audio streams and audio/video synchronization. 31 // VoiceEngine used for audio streams and audio/video synchronization.
27 // AudioState will tickle the VoE refcount to keep it alive for as long as 32 // AudioState will tickle the VoE refcount to keep it alive for as long as
28 // the AudioState itself. 33 // the AudioState itself.
29 VoiceEngine* voice_engine = nullptr; 34 VoiceEngine* voice_engine = nullptr;
30 35
31 // The AudioDeviceModule associated with the Calls. 36 // The AudioDeviceModule associated with the Calls.
32 AudioDeviceModule* audio_device_module = nullptr; 37 AudioDeviceModule* audio_device_module = nullptr;
33 }; 38 };
34 39
35 // TODO(solenberg): Replace scoped_refptr with shared_ptr once we can use it. 40 // TODO(solenberg): Replace scoped_refptr with shared_ptr once we can use it.
36 static rtc::scoped_refptr<AudioState> Create( 41 static rtc::scoped_refptr<AudioState> Create(
37 const AudioState::Config& config); 42 const AudioState::Config& config);
38 43
39 virtual ~AudioState() {} 44 virtual ~AudioState() {}
40 }; 45 };
41 } // namespace webrtc 46 } // namespace webrtc
42 47
43 #endif // WEBRTC_AUDIO_STATE_H_ 48 #endif // WEBRTC_AUDIO_STATE_H_
OLDNEW
« no previous file with comments | « webrtc/audio_send_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698