Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: webrtc/voice_engine/voe_base_unittest.cc

Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/voe_base_impl.cc ('k') | webrtc/voice_engine/voice_engine_defines.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/voe_base_unittest.cc
diff --git a/webrtc/voice_engine/voe_base_unittest.cc b/webrtc/voice_engine/voe_base_unittest.cc
index 5c71784b4f997f8ba87e15d0f52fb0022d6e8036..ff97f3208fa77b9b41aa7da7457e52e63da68ed4 100644
--- a/webrtc/voice_engine/voe_base_unittest.cc
+++ b/webrtc/voice_engine/voe_base_unittest.cc
@@ -78,4 +78,10 @@ TEST_F(VoEBaseTest, AssociateSendChannel) {
EXPECT_EQ(1, reference.use_count());
}
+TEST_F(VoEBaseTest, GetVersion) {
+ char v1[1024] = {0};
kwiberg-webrtc 2015/12/02 10:50:12 Or fill it with something other than zeros, to tes
+ base_->GetVersion(v1);
+ std::string v2 = VoiceEngine::GetVersionString() + "\n";
+ EXPECT_EQ(v2, v1);
+}
} // namespace webrtc
« no previous file with comments | « webrtc/voice_engine/voe_base_impl.cc ('k') | webrtc/voice_engine/voice_engine_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698