Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1487893004: Replace EventWrapper in video/, test/ and call/. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace EventWrapper in video/, test/ and call/. Makes use of rtc::Event which is simpler and can be used without allocating additional objects on the heap. Does not modify test/channel_transport/. BUG= R=mflodman@webrtc.org Committed: https://crrev.com/5811a39f14fd77ebc0793ee93d03ee15a669bd8f Cr-Commit-Position: refs/heads/master@{#10968}

Patch Set 1 #

Total comments: 12

Patch Set 2 : rebase #

Patch Set 3 : replace event_wrapper.h includes #

Patch Set 4 : add some back, EventTimerWrapper is in use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -294 lines) Patch
M webrtc/call/bitrate_estimator_tests.cc View 1 2 10 chunks +16 lines, -18 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 1 12 chunks +16 lines, -18 lines 0 comments Download
M webrtc/test/call_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/direct_transport.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/test/direct_transport.cc View 1 4 chunks +5 lines, -13 lines 0 comments Download
M webrtc/test/fake_network_pipe.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/rtp_rtcp_observer.h View 1 4 chunks +6 lines, -8 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 68 chunks +123 lines, -133 lines 0 comments Download
M webrtc/video/rampup_tests.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/rampup_tests.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M webrtc/video/video_capture_input.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 1 2 5 chunks +4 lines, -5 lines 0 comments Download
M webrtc/video/video_capture_input_unittest.cc View 1 2 7 chunks +12 lines, -13 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 9 chunks +17 lines, -22 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 37 chunks +40 lines, -50 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
pbos-webrtc
PTAL
5 years ago (2015-12-01 12:17:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487893004/1
5 years ago (2015-12-01 12:18:20 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-01 14:18:32 UTC) #5
mflodman
A bunch of include event_wrapper.h remaining, remove these and then LGTM. https://codereview.webrtc.org/1487893004/diff/1/webrtc/call/bitrate_estimator_tests.cc File webrtc/call/bitrate_estimator_tests.cc (right): ...
5 years ago (2015-12-10 08:11:34 UTC) #6
pbos-webrtc
rebase
5 years ago (2015-12-10 11:38:01 UTC) #7
pbos-webrtc
replace event_wrapper.h includes
5 years ago (2015-12-10 11:41:00 UTC) #8
pbos-webrtc
add some back, EventTimerWrapper is in use
5 years ago (2015-12-10 11:43:06 UTC) #9
pbos-webrtc
https://codereview.webrtc.org/1487893004/diff/1/webrtc/call/bitrate_estimator_tests.cc File webrtc/call/bitrate_estimator_tests.cc (right): https://codereview.webrtc.org/1487893004/diff/1/webrtc/call/bitrate_estimator_tests.cc#newcode22 webrtc/call/bitrate_estimator_tests.cc:22: #include "webrtc/system_wrappers/include/event_wrapper.h" On 2015/12/10 08:11:34, mflodman wrote: > Remove. ...
5 years ago (2015-12-10 11:44:55 UTC) #10
pbos-webrtc
Committed patchset #4 (id:60001) manually as 5811a39f14fd77ebc0793ee93d03ee15a669bd8f (presubmit successful).
5 years ago (2015-12-10 12:03:06 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 12:03:11 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5811a39f14fd77ebc0793ee93d03ee15a669bd8f
Cr-Commit-Position: refs/heads/master@{#10968}

Powered by Google App Engine
This is Rietveld 408576698