Chromium Code Reviews

Unified Diff: webrtc/test/rtp_rtcp_observer.h

Issue 1487893004: Replace EventWrapper in video/, test/ and call/. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: add some back, EventTimerWrapper is in use Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webrtc/test/fake_network_pipe.h ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/rtp_rtcp_observer.h
diff --git a/webrtc/test/rtp_rtcp_observer.h b/webrtc/test/rtp_rtcp_observer.h
index f8d696c763e1ec5ca3ac93ab8fd0bd9296aada4e..5eb88d3f0d33ecb7178d165e816ce03c35d2b90c 100644
--- a/webrtc/test/rtp_rtcp_observer.h
+++ b/webrtc/test/rtp_rtcp_observer.h
@@ -16,6 +16,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "webrtc/base/criticalsection.h"
+#include "webrtc/base/event.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_header_parser.h"
#include "webrtc/test/constants.h"
#include "webrtc/test/direct_transport.h"
@@ -36,10 +37,7 @@ class RtpRtcpObserver {
virtual ~RtpRtcpObserver() {}
- virtual EventTypeWrapper Wait() {
- EventTypeWrapper result = observation_complete_->Wait(timeout_ms_);
- return result;
- }
+ virtual bool Wait() { return observation_complete_.Wait(timeout_ms_); }
virtual Action OnSendRtp(const uint8_t* packet, size_t length) {
return SEND_PACKET;
@@ -58,8 +56,8 @@ class RtpRtcpObserver {
}
protected:
- explicit RtpRtcpObserver(unsigned int event_timeout_ms)
- : observation_complete_(EventWrapper::Create()),
+ explicit RtpRtcpObserver(int event_timeout_ms)
+ : observation_complete_(false, false),
parser_(RtpHeaderParser::Create()),
timeout_ms_(event_timeout_ms) {
parser_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
@@ -70,11 +68,11 @@ class RtpRtcpObserver {
kTransportSequenceNumberExtensionId);
}
- const rtc::scoped_ptr<EventWrapper> observation_complete_;
+ rtc::Event observation_complete_;
const rtc::scoped_ptr<RtpHeaderParser> parser_;
private:
- unsigned int timeout_ms_;
+ const int timeout_ms_;
};
class PacketTransport : public test::DirectTransport {
« no previous file with comments | « webrtc/test/fake_network_pipe.h ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine