Return a copy of the supported RTP header extensions instead of a reference.

Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=webrtc:5187
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/9d69c3f4d99240c27d997c37950b561605d403bd
Cr-Commit-Position: refs/heads/master@{#10910}

[stefan-webrtc, 2015-12-01 14:48:40]

.

[stefan-webrtc, 2015-12-01 14:48:49]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 14:48:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486123002/20001

[stefan-webrtc, 2015-12-01 14:51:36]

stefan@webrtc.org changed reviewers:
+ pbos@webrtc.org, pthatcher@webrtc.org

[pbos-webrtc, 2015-12-01 15:05:51]

Description was changed from

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=5187
==========

to

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=chromium:5187
==========

[pbos-webrtc, 2015-12-01 15:06:03]

Description was changed from

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=chromium:5187
==========

to

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=webrtc:5187
==========

[pbos-webrtc, 2015-12-01 15:09:22]

lgtm

[commit-bot: I haz the power, 2015-12-01 17:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 17:08:48]

Dry run: This issue passed the CQ dry run.

[pthatcher1, 2015-12-01 18:40:47]

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/fakemedia...
File talk/media/base/fakemediaengine.h (right):

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/fakemedia...
talk/media/base/fakemediaengine.h:701: std::vector<RtpHeaderExtension>
SupportedRtpHeaderExtensions() const {
Can we please just skip right to what we want this to be called eventually?

RtpCapabilities GetCapabilities();

struct RtpCapabilities {
  std::vector<RtpHeaderExtension> header_extensions;
};

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/mediaengi...
File talk/media/base/mediaengine.h (right):

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/mediaengi...
talk/media/base/mediaengine.h:111: virtual std::vector<RtpHeaderExtension>
audio_rtp_header_extensions() = 0;
This is only called in one place (channelmanager.cc), so I think we should its
name as well, preferably to GetAudioCapabilities() and GetVideoCapabilities().

[stefan-webrtc, 2015-12-04 14:06:11]

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/fakemedia...
File talk/media/base/fakemediaengine.h (right):

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/fakemedia...
talk/media/base/fakemediaengine.h:701: std::vector<RtpHeaderExtension>
SupportedRtpHeaderExtensions() const {
On 2015/12/01 18:40:46, pthatcher1 wrote:
> Can we please just skip right to what we want this to be called eventually?
> 
> RtpCapabilities GetCapabilities();
> 
> struct RtpCapabilities {
>   std::vector<RtpHeaderExtension> header_extensions;
> };
> 

Done.

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/mediaengi...
File talk/media/base/mediaengine.h (right):

https://codereview.webrtc.org/1486123002/diff/20001/talk/media/base/mediaengi...
talk/media/base/mediaengine.h:111: virtual std::vector<RtpHeaderExtension>
audio_rtp_header_extensions() = 0;
On 2015/12/01 18:40:46, pthatcher1 wrote:
> This is only called in one place (channelmanager.cc), so I think we should its
> name as well, preferably to GetAudioCapabilities() and GetVideoCapabilities().

Done.

[stefan-webrtc, 2015-12-04 14:06:19]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 14:06:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486123002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486123002/40001

[pbos-webrtc, 2015-12-04 14:18:24]

If it's not too much work, feel free to add the codecs to this list as well.
Otherwise punt.

https://codereview.webrtc.org/1486123002/diff/40001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1486123002/diff/40001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2.cc:538: RtpCapabilities
clang-format this fits on one line

[stefan-webrtc, 2015-12-04 14:30:20]

Format.

[stefan-webrtc, 2015-12-04 14:32:09]

I really need this in soon so that we can start testing with SendSideBwe,
therefore I don't want it to grow more than this. Let's leave any further
improvements for future CLs.

https://codereview.webrtc.org/1486123002/diff/40001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1486123002/diff/40001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2.cc:538: RtpCapabilities
On 2015/12/04 14:18:24, pbos-webrtc wrote:
> clang-format this fits on one line

Done.

[pbos-webrtc, 2015-12-04 14:36:18]

fine with me, lgtm

[pthatcher1, 2015-12-04 17:57:30]

lgtm

I like it.

[stefan-webrtc, 2015-12-04 17:59:35]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-12-04 17:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486123002/60001

[commit-bot: I haz the power, 2015-12-04 19:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 19:59:59]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2015-12-07 08:47:31]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-12-07 08:47:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486123002/60001

[stefan-webrtc, 2015-12-07 09:45:34]

Merge

[stefan-webrtc, 2015-12-07 09:45:54]

Description was changed from

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=webrtc:5187
==========

to

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=webrtc:5187
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/9d69c3f4d99240c27d997c379...
==========

[stefan-webrtc, 2015-12-07 09:45:55]

Committed patchset #5 (id:80001) manually as
9d69c3f4d99240c27d997c37950b561605d403bd (presubmit successful).

[commit-bot: I haz the power, 2015-12-07 09:45:56]

Description was changed from

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=webrtc:5187
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/9d69c3f4d99240c27d997c379...
==========

to

==========
Return a copy of the supported RTP header extensions instead of a reference.

This also renames the method to better reflect what it does.

BUG=webrtc:5187
R=pbos@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/9d69c3f4d99240c27d997c37950b561605d403bd
Cr-Commit-Position: refs/heads/master@{#10910}
==========

[commit-bot: I haz the power, 2015-12-07 09:45:57]

Patchset 5 (id:??) landed as
https://crrev.com/9d69c3f4d99240c27d997c37950b561605d403bd
Cr-Commit-Position: refs/heads/master@{#10910}