Return a copy of the supported RTP header extensions instead of a reference.

talk/media/base/fakemediaengine.h

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 680 matching lines @@
 
 // A base class for all of the shared parts between FakeVoiceEngine
 // and FakeVideoEngine.
 class FakeBaseEngine {
  public:
   FakeBaseEngine()
       : options_changed_(false),
         fail_create_channel_(false) {}
   void set_fail_create_channel(bool fail) { fail_create_channel_ = fail; }
 
-  const std::vector<RtpHeaderExtension>& rtp_header_extensions() const {
+  std::vector<RtpHeaderExtension> SupportedRtpHeaderExtensions() const {

[pthatcher1, 2015/12/01 18:40:46]

Can we please just skip right to what we want this to be called eventually?

RtpCapabilities GetCapabilities();

struct RtpCapabilities {
  std::vector<RtpHeaderExtension> header_extensions;
};

[stefan-webrtc, 2015/12/04 14:06:10]

Done.

     return rtp_header_extensions_;
   }
   void set_rtp_header_extensions(
       const std::vector<RtpHeaderExtension>& extensions) {
     rtp_header_extensions_ = extensions;
   }
 
  protected:
   // Flag used by optionsmessagehandler_unittest for checking whether any
   // relevant setting has been updated.
@@ skipping 263 matching lines @@
 
  private:
   std::vector<FakeDataMediaChannel*> channels_;
   std::vector<DataCodec> data_codecs_;
   DataChannelType last_channel_type_;
 };
 
 }  // namespace cricket
 
 #endif  // TALK_MEDIA_BASE_FAKEMEDIAENGINE_H_