Use webrtc/base/logging.h in stefan@'s ownership.

Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org

Committed: https://crrev.com/7c704b82893bbe7fc206b004fb9dfe6e69a986ef
Cr-Commit-Position: refs/heads/master@{#10896}

[stefan-webrtc, 2015-11-27 18:33:49]

lgtm

[stefan-webrtc, 2015-11-27 18:33:52]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-11-27 18:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484503002/1

[commit-bot: I haz the power, 2015-11-27 18:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 18:41:45]

Try jobs failed on following builders:
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/11150)

[pbos-webrtc, 2015-12-03 22:57:20]

use rtc logging in bitrate estimator tests

[pbos-webrtc, 2015-12-03 22:58:35]

PTAL, also had to ignore a message due to AST extensions missing (not sure if we
got away with that in tracing because it was racy somehow).

https://codereview.webrtc.org/1484503002/diff/20001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/1484503002/diff/20001/webrtc/call/call.cc#newco...
webrtc/call/call.cc:129: bool network_enabled_;
(part of rebase)

[pbos-webrtc, 2015-12-03 22:59:15]

Namely I had to ignore this:

(remote_bitrate_estimator_abs_send_time.cc:242):
RemoteBitrateEstimatorAbsSendTimeImpl: Incoming packet is missing absolute send
time extension!

[pbos-webrtc, 2015-12-04 09:56:34]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 09:56:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484503002/20001

[commit-bot: I haz the power, 2015-12-04 11:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 11:45:18]

Dry run: Try jobs failed on following builders:
  win_drmemory_light on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...)

[pbos-webrtc, 2015-12-04 13:13:22]

Description was changed from

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org
==========

to

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

Also fixes logging race in SwitchesToASTThenBackToTOFForVideo.

BUG=webrtc:5118, webrtc:5225
R=stefan@webrtc.org
==========

[pbos-webrtc, 2015-12-04 13:44:49]

Description was changed from

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

Also fixes logging race in SwitchesToASTThenBackToTOFForVideo.

BUG=webrtc:5118, webrtc:5225
R=stefan@webrtc.org
==========

to

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org
==========

[stefan-webrtc, 2015-12-04 14:02:37]

https://codereview.webrtc.org/1484503002/diff/20001/webrtc/call/bitrate_estim...
File webrtc/call/bitrate_estimator_tests.cc (right):

https://codereview.webrtc.org/1484503002/diff/20001/webrtc/call/bitrate_estim...
webrtc/call/bitrate_estimator_tests.cc:60: message.find("packet is missing") ==
std::string::npos) {
Could you explain why you changed the behavior?

[pbos-webrtc, 2015-12-04 14:11:11]

change back to LS_INFO

[pbos-webrtc, 2015-12-04 14:12:01]

PTAL, I'm not sure why this logline didn't reach the filter before :\

https://codereview.webrtc.org/1484503002/diff/20001/webrtc/call/bitrate_estim...
File webrtc/call/bitrate_estimator_tests.cc (right):

https://codereview.webrtc.org/1484503002/diff/20001/webrtc/call/bitrate_estim...
webrtc/call/bitrate_estimator_tests.cc:60: message.find("packet is missing") ==
std::string::npos) {
On 2015/12/04 14:02:37, stefan-webrtc (holmer) wrote:
> Could you explain why you changed the behavior?

This was logged before I think, but might have been filtered out (loglevels not
matching), or something like that.

[pbos-webrtc, 2015-12-04 14:49:47]

improved logging + ignore packet in abssendtime

[pbos-webrtc, 2015-12-04 14:52:26]

PTAL, and I added a return so that TOF packets aren't accounted for in AST

[stefan-webrtc, 2015-12-04 15:05:51]

lgtm

[pbos-webrtc, 2015-12-04 15:13:17]

Description was changed from

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org
==========

to

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7c704b82893bbe7fc206b004f...
==========

[pbos-webrtc, 2015-12-04 15:13:19]

Committed patchset #4 (id:60001) manually as
7c704b82893bbe7fc206b004fb9dfe6e69a986ef (presubmit successful).

[commit-bot: I haz the power, 2015-12-04 15:13:22]

Description was changed from

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7c704b82893bbe7fc206b004f...
==========

to

==========
Use webrtc/base/logging.h in stefan@'s ownership.

Replaces system_wrappers' logging in call/, bitrate_controller/, pacing/
and remote_bitrate_estimator/.

BUG=webrtc:5118
R=stefan@webrtc.org

Committed: https://crrev.com/7c704b82893bbe7fc206b004fb9dfe6e69a986ef
Cr-Commit-Position: refs/heads/master@{#10896}
==========

[commit-bot: I haz the power, 2015-12-04 15:13:23]

Patchset 4 (id:??) landed as
https://crrev.com/7c704b82893bbe7fc206b004fb9dfe6e69a986ef
Cr-Commit-Position: refs/heads/master@{#10896}