webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc - Issue 1484503002: Use webrtc/base/logging.h in stefan@'s ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

Issue 1484503002: Use webrtc/base/logging.h in stefan@'s ownership. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: improved logging + ignore packet in abssendtime Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

index 51f7d4320a645be07aae0156ce956d64e6b3712e..8006fe82a2be7b8435643d29e0a680572d38cb86 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

@@ -13,13 +13,13 @@

#include <math.h>

#include "webrtc/base/constructormagic.h"

+#include "webrtc/base/logging.h"

#include "webrtc/base/scoped_ptr.h"

#include "webrtc/base/thread_annotations.h"

-#include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h"

#include "webrtc/modules/pacing/paced_sender.h"

+#include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h"

#include "webrtc/system_wrappers/include/clock.h"

#include "webrtc/system_wrappers/include/critical_section_wrapper.h"

-#include "webrtc/system_wrappers/include/logging.h"

#include "webrtc/typedefs.h"

namespace webrtc {

@@ -241,6 +241,7 @@ void RemoteBitrateEstimatorAbsSendTime::IncomingPacket(int64_t arrival_time_ms,

if (!header.extension.hasAbsoluteSendTime) {

LOG(LS_WARNING) << "RemoteBitrateEstimatorAbsSendTimeImpl: Incoming packet "

"is missing absolute send time extension!";

+ return;

}

IncomingPacketInfo(arrival_time_ms, header.extension.absoluteSendTime,

payload_size, header.ssrc, was_paced);