Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1483323002: Enable cpplint for webrtc/audio and webrtc/call, and fix all uncovered cpplint errors. (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable cpplint for webrtc/audio and webrtc/call, and fix all uncovered cpplint errors. BUG=webrtc:5268, webrtc:5273 TESTED=Fixed issues reported by: find webrtc/audio -type f -name *.cc -o -name *.h | xargs cpplint.py find webrtc/call -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. R=kjellander@webrtc.org, pbos@webrtc.org Committed: https://crrev.com/ea07373a2eb46f2732a8b5acef06a9b5078f37f8 Cr-Commit-Position: refs/heads/master@{#10853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/rtc_event_log_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
the sun
5 years ago (2015-12-01 09:20:54 UTC) #2
kjellander_webrtc
Nice to see work done on this even before the Fixit. I changed the bugs ...
5 years ago (2015-12-01 09:38:26 UTC) #8
the sun
On 2015/12/01 09:38:26, kjellander (webrtc) wrote: > Nice to see work done on this even ...
5 years ago (2015-12-01 09:41:40 UTC) #9
pbos-webrtc
lgtm, just land it
5 years ago (2015-12-01 09:43:00 UTC) #10
kjellander_webrtc
On 2015/12/01 09:41:40, the sun wrote: > On 2015/12/01 09:38:26, kjellander (webrtc) wrote: > > ...
5 years ago (2015-12-01 09:44:34 UTC) #11
the sun
Committed patchset #1 (id:1) manually as ea07373a2eb46f2732a8b5acef06a9b5078f37f8 (presubmit successful).
5 years ago (2015-12-01 10:26:52 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-01 10:26:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea07373a2eb46f2732a8b5acef06a9b5078f37f8
Cr-Commit-Position: refs/heads/master@{#10853}

Powered by Google App Engine
This is Rietveld 408576698