Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: PRESUBMIT.py

Issue 1483323002: Enable cpplint for webrtc/audio and webrtc/call, and fix all uncovered cpplint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/audio/audio_receive_stream_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
11 import platform 11 import platform
12 import re 12 import re
13 import subprocess 13 import subprocess
14 import sys 14 import sys
15 15
16 16
17 # Directories that will be scanned by cpplint by the presubmit script. 17 # Directories that will be scanned by cpplint by the presubmit script.
18 CPPLINT_DIRS = [ 18 CPPLINT_DIRS = [
19 'webrtc/audio',
20 'webrtc/call',
19 'webrtc/video_engine', 21 'webrtc/video_engine',
20 ] 22 ]
21 23
22 24
23 def _CheckNoIOStreamInHeaders(input_api, output_api): 25 def _CheckNoIOStreamInHeaders(input_api, output_api):
24 """Checks to make sure no .h files include <iostream>.""" 26 """Checks to make sure no .h files include <iostream>."""
25 files = [] 27 files = []
26 pattern = input_api.re.compile(r'^#include\s*<iostream>', 28 pattern = input_api.re.compile(r'^#include\s*<iostream>',
27 input_api.re.MULTILINE) 29 input_api.re.MULTILINE)
28 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): 30 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 for builder in masters[master]: 376 for builder in masters[master]:
375 if 'presubmit' in builder: 377 if 'presubmit' in builder:
376 # Do not trigger presubmit builders, since they're likely to fail 378 # Do not trigger presubmit builders, since they're likely to fail
377 # (e.g. OWNERS checks before finished code review), and we're running 379 # (e.g. OWNERS checks before finished code review), and we're running
378 # local presubmit anyway. 380 # local presubmit anyway.
379 pass 381 pass
380 else: 382 else:
381 try_config[master][builder] = ['defaulttests'] 383 try_config[master][builder] = ['defaulttests']
382 384
383 return try_config 385 return try_config
OLDNEW
« no previous file with comments | « no previous file | webrtc/audio/audio_receive_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698