Strip IP addresses in NDEBUG (release) builds.

Strip IP addresses in NDEBUG (release) builds.

Also removes the ability to override (set) this.

BUG=
R=pthatcher@webrtc.org

Committed: https://crrev.com/cdb38e53978c27d0ccb9a7ccc987508122b2bc69
Cr-Commit-Position: refs/heads/master@{#10796}

[pbos-webrtc, 2015-11-25 23:04:13]

Description was changed from

==========
Strip IP addresses in NDEBUG (release) builds.

BUG=
R=pthatcher@webrtc.org
==========

to

==========
Strip IP addresses in NDEBUG (release) builds.

Also removes the ability to override (set) this.

BUG=
R=pthatcher@webrtc.org
==========

[pthatcher1, 2015-11-25 23:08:23]

lgtm

https://codereview.webrtc.org/1480743002/diff/1/webrtc/base/ipaddress.h
File webrtc/base/ipaddress.h (left):

https://codereview.webrtc.org/1480743002/diff/1/webrtc/base/ipaddress.h#oldco...
webrtc/base/ipaddress.h:115: static void set_strip_sensitive(bool enable);
This is going to break Chrome FYI bots, is it not?  You might want to two-step
this.

[pbos-webrtc, 2015-11-25 23:09:52]

https://codereview.webrtc.org/1480743002/diff/1/webrtc/base/ipaddress.h
File webrtc/base/ipaddress.h (left):

https://codereview.webrtc.org/1480743002/diff/1/webrtc/base/ipaddress.h#oldco...
webrtc/base/ipaddress.h:115: static void set_strip_sensitive(bool enable);
On 2015/11/25 23:08:23, pthatcher1 wrote:
> This is going to break Chrome FYI bots, is it not?  You might want to two-step
> this.

I already broke them (due to nacl), this will help fixing them. :\

[pbos-webrtc, 2015-11-25 23:09:57]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-11-25 23:10:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480743002/1

[commit-bot: I haz the power, 2015-11-25 23:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 23:23:45]

Try jobs failed on following builders:
  mac_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/10865)

[pbos-webrtc, 2015-11-25 23:35:32]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-11-25 23:35:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480743002/1

[pbos-webrtc, 2015-11-25 23:36:24]

Description was changed from

==========
Strip IP addresses in NDEBUG (release) builds.

Also removes the ability to override (set) this.

BUG=
R=pthatcher@webrtc.org
==========

to

==========
Strip IP addresses in NDEBUG (release) builds.

Also removes the ability to override (set) this.

BUG=
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/cdb38e53978c27d0ccb9a7ccc...
==========

[pbos-webrtc, 2015-11-25 23:36:26]

Committed patchset #1 (id:1) manually as
cdb38e53978c27d0ccb9a7ccc987508122b2bc69 (presubmit successful).

[commit-bot: I haz the power, 2015-11-25 23:36:28]

Description was changed from

==========
Strip IP addresses in NDEBUG (release) builds.

Also removes the ability to override (set) this.

BUG=
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/cdb38e53978c27d0ccb9a7ccc...
==========

to

==========
Strip IP addresses in NDEBUG (release) builds.

Also removes the ability to override (set) this.

BUG=
R=pthatcher@webrtc.org

Committed: https://crrev.com/cdb38e53978c27d0ccb9a7ccc987508122b2bc69
Cr-Commit-Position: refs/heads/master@{#10796}
==========

[commit-bot: I haz the power, 2015-11-25 23:36:30]

Patchset 1 (id:??) landed as
https://crrev.com/cdb38e53978c27d0ccb9a7ccc987508122b2bc69
Cr-Commit-Position: refs/heads/master@{#10796}