Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: webrtc/base/socketaddress_unittest.cc

Issue 1480743002: Strip IP addresses in NDEBUG (release) builds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« webrtc/base/ipaddress.h ('K') | « webrtc/base/ipaddress_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 318
319 SocketAddress addr3("a.b.c.d", 1); 319 SocketAddress addr3("a.b.c.d", 1);
320 SocketAddress addr4("b.b.c.d", 1); 320 SocketAddress addr4("b.b.c.d", 1);
321 EXPECT_PRED2(IsLessThan, addr3, addr4); 321 EXPECT_PRED2(IsLessThan, addr3, addr4);
322 } 322 }
323 323
324 TEST(SocketAddressTest, TestToSensitiveString) { 324 TEST(SocketAddressTest, TestToSensitiveString) {
325 SocketAddress addr_v4("1.2.3.4", 5678); 325 SocketAddress addr_v4("1.2.3.4", 5678);
326 EXPECT_EQ("1.2.3.4", addr_v4.HostAsURIString()); 326 EXPECT_EQ("1.2.3.4", addr_v4.HostAsURIString());
327 EXPECT_EQ("1.2.3.4:5678", addr_v4.ToString()); 327 EXPECT_EQ("1.2.3.4:5678", addr_v4.ToString());
328
329 #if defined(NDEBUG)
330 EXPECT_EQ("1.2.3.x", addr_v4.HostAsSensitiveURIString());
331 EXPECT_EQ("1.2.3.x:5678", addr_v4.ToSensitiveString());
332 #else
328 EXPECT_EQ("1.2.3.4", addr_v4.HostAsSensitiveURIString()); 333 EXPECT_EQ("1.2.3.4", addr_v4.HostAsSensitiveURIString());
329 EXPECT_EQ("1.2.3.4:5678", addr_v4.ToSensitiveString()); 334 EXPECT_EQ("1.2.3.4:5678", addr_v4.ToSensitiveString());
330 IPAddress::set_strip_sensitive(true); 335 #endif // defined(NDEBUG)
331 EXPECT_EQ("1.2.3.x", addr_v4.HostAsSensitiveURIString());
332 EXPECT_EQ("1.2.3.x:5678", addr_v4.ToSensitiveString());
333 IPAddress::set_strip_sensitive(false);
334 336
335 SocketAddress addr_v6(kTestV6AddrString, 5678); 337 SocketAddress addr_v6(kTestV6AddrString, 5678);
336 EXPECT_EQ("[" + kTestV6AddrString + "]", addr_v6.HostAsURIString()); 338 EXPECT_EQ("[" + kTestV6AddrString + "]", addr_v6.HostAsURIString());
337 EXPECT_EQ(kTestV6AddrFullString, addr_v6.ToString()); 339 EXPECT_EQ(kTestV6AddrFullString, addr_v6.ToString());
338 EXPECT_EQ("[" + kTestV6AddrString + "]", addr_v6.HostAsSensitiveURIString()); 340 #if defined(NDEBUG)
339 EXPECT_EQ(kTestV6AddrFullString, addr_v6.ToSensitiveString());
340 IPAddress::set_strip_sensitive(true);
341 EXPECT_EQ("[" + kTestV6AddrAnonymizedString + "]", 341 EXPECT_EQ("[" + kTestV6AddrAnonymizedString + "]",
342 addr_v6.HostAsSensitiveURIString()); 342 addr_v6.HostAsSensitiveURIString());
343 EXPECT_EQ(kTestV6AddrFullAnonymizedString, addr_v6.ToSensitiveString()); 343 EXPECT_EQ(kTestV6AddrFullAnonymizedString, addr_v6.ToSensitiveString());
344 IPAddress::set_strip_sensitive(false); 344 #else
345 EXPECT_EQ("[" + kTestV6AddrString + "]", addr_v6.HostAsSensitiveURIString());
346 EXPECT_EQ(kTestV6AddrFullString, addr_v6.ToSensitiveString());
347 #endif // defined(NDEBUG)
345 } 348 }
346 349
347 } // namespace rtc 350 } // namespace rtc
OLDNEW
« webrtc/base/ipaddress.h ('K') | « webrtc/base/ipaddress_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698