Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1468113002: Reland of Adding the ability to create an RtpSender without a track. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Adding the ability to create an RtpSender without a track. (patchset #8 id:140001 of https://codereview.webrtc.org/1413713003/ ) Relanding after fixing CallAndModifyStream to account for new procedures for adding/removing a track from a stream. Original issue's description: > Adding the ability to create an RtpSender without a track. > > This CL also changes AddStream to immediately create a sender, rather > than waiting until the track is seen in SDP. And the PeerConnection now > builds the list of "send streams" from the list of senders, rather than > the collection of local media streams. > > Committed: https://crrev.com/ac9d92ccbe2b29590c53f702e11dc625820480d5 > Cr-Commit-Position: refs/heads/master@{#10414} Committed: https://crrev.com/fac0655fd7fe0b40ef50dc5b7f11ea44d72cec6c Cr-Commit-Position: refs/heads/master@{#10790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+713 lines, -259 lines) Patch
M talk/app/webrtc/audiotrack.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/mediastreaminterface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/mediastreamprovider.h View 2 chunks +4 lines, -5 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 3 chunks +5 lines, -6 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 12 chunks +115 lines, -135 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 6 chunks +59 lines, -29 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionproxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/rtpsender.h View 5 chunks +58 lines, -11 lines 0 comments Download
M talk/app/webrtc/rtpsender.cc View 5 chunks +165 lines, -53 lines 0 comments Download
M talk/app/webrtc/rtpsenderinterface.h View 3 chunks +20 lines, -0 lines 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 4 chunks +210 lines, -3 lines 0 comments Download
M talk/app/webrtc/videotrack.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/base/helpers.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/helpers.cc View 2 chunks +49 lines, -10 lines 0 comments Download
M webrtc/base/helpers_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor Brandstetter
Created Reland of Adding the ability to create an RtpSender without a track.
5 years, 1 month ago (2015-11-23 17:53:31 UTC) #1
pthatcher1
lgtm
5 years, 1 month ago (2015-11-23 20:39:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468113002/1
5 years ago (2015-11-25 17:36:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 19:26:05 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 19:26:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac0655fd7fe0b40ef50dc5b7f11ea44d72cec6c
Cr-Commit-Position: refs/heads/master@{#10790}

Powered by Google App Engine
This is Rietveld 408576698