Create webrtc/base/objc and move some logging code there

Leaving all original files in talk/app/webrtc/objc until we can officially tell clients about the new locations.

Also changes presubmit script to not run cpplint on objc dirs.

BUG=

Committed: https://crrev.com/42f580e490e8343a87362dbb20207380d850372c
Cr-Commit-Position: refs/heads/master@{#10815}

[tkchin_webrtc, 2015-11-24 00:14:41]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2015-11-24 00:16:01]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2015-11-24 00:17:07]

tkchin@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, tommi@webrtc.org

[tommi, 2015-11-24 06:39:24]

Lgtm. Can you mention the logging change too in the description?

[pthatcher, 2015-11-24 19:15:55]

pthatcher@google.com changed reviewers:
+ pthatcher@google.com

[pthatcher, 2015-11-24 19:15:55]

lgtm

+1 to Tommi's comment.

[tkchin_webrtc, 2015-11-24 19:20:40]

Description was changed from

==========
Create webrtc/base/objc

BUG=
==========

to

==========
Create webrtc/base/objc and move some logging code there.

Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

BUG=
==========

[tkchin_webrtc, 2015-11-24 19:20:40]

tkchin@webrtc.org changed reviewers:
- pthatcher@google.com

[tkchin_webrtc, 2015-11-24 19:20:59]

Description was changed from

==========
Create webrtc/base/objc and move some logging code there.

Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

BUG=
==========

to

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

BUG=
==========

[tkchin_webrtc, 2015-11-24 22:02:16]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2015-11-24 22:02:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
pthatcher@google.com
Link to the patchset: https://codereview.webrtc.org/1467173006/#ps60001 (title:
"Fix rename error")

[commit-bot: I haz the power, 2015-11-24 22:02:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467173006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467173006/60001

[commit-bot: I haz the power, 2015-11-24 22:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 22:05:54]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1950)

[tkchin_webrtc, 2015-11-24 22:41:34]

Description was changed from

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

BUG=
==========

to

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

Also changes presubmit script to not run cpplint on objc dirs.

BUG=
==========

[tkchin_webrtc, 2015-11-24 22:41:34]

tkchin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[tkchin_webrtc, 2015-11-24 22:45:13]

@kjellander could you look at the presubmit change? Would be nice to have commit
queue for ObjC

Also, GN still doesn't work for iOS/ObjC yes? I think when that changes we can
just look at all objc rules and updated them accordingly.

[kjellander_webrtc, 2015-11-25 09:03:35]

On 2015/11/24 22:45:13, tkchin_webrtc wrote:
> @kjellander could you look at the presubmit change? Would be nice to have
commit
> queue for ObjC

Do we really need to exclude objc dir from cpplint? The error looks easy to fix
for the header file (missing header guard):

/b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.h:0:  No #ifndef
header guard found, suggested CPP variable is: WEBRTC_BASE_OBJC_RTCLOGGING_H_ 
[build/header_guard] [5]
Done processing /b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.h
Ignoring /b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.mm; not a
valid file name (cc, h, cpp, cu, cuh)
Done processing /b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.mm

The .mm file is already not checked (see
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/cppl...)
due to its extension.

> Also, GN still doesn't work for iOS/ObjC yes? I think when that changes we can
> just look at all objc rules and updated them accordingly.

I believe the GN support for iOS is mostly done now and the Chromium folks are
working hard to get it building, so please update BUILD.gn as well in this CL. 
Our own iOS GN bots are still not green though, so they won't help you verify
the correctness (https://bugs.chromium.org/p/webrtc/issues/detail?id=5195).

[tkchin_webrtc, 2015-11-26 06:51:00]

On 2015/11/25 09:03:35, kjellander (webrtc) wrote:
> On 2015/11/24 22:45:13, tkchin_webrtc wrote:
> > @kjellander could you look at the presubmit change? Would be nice to have
> commit
> > queue for ObjC
> 
> Do we really need to exclude objc dir from cpplint? The error looks easy to
fix
> for the header file (missing header guard):
> 
Yeah we do. ObjC headers end in .h and will contain ObjC bits that cpplint won't
like. e.g. @interface decls. The missing header guard is also a no-op because
ObjC headers are #import-ed not #include-ed and don't require a header guard.
Mostly this is a convenient way to declare that .h shouldn't be analyzed because
it's not actually C++.

> /b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.h:0:  No #ifndef
> header guard found, suggested CPP variable is: WEBRTC_BASE_OBJC_RTCLOGGING_H_ 
> [build/header_guard] [5]
> Done processing /b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.h
> Ignoring /b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.mm; not
a
> valid file name (cc, h, cpp, cu, cuh)
> Done processing
/b/build/slave/linux64/build/src/webrtc/base/objc/RTCLogging.mm
> 
> The .mm file is already not checked (see
>
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/cppl...)
> due to its extension.
> 
Yup, but it's nice to silence the warning that it's being ignored.

> > Also, GN still doesn't work for iOS/ObjC yes? I think when that changes we
can
> > just look at all objc rules and updated them accordingly.
> 
> I believe the GN support for iOS is mostly done now and the Chromium folks are
> working hard to get it building, so please update BUILD.gn as well in this CL.

> Our own iOS GN bots are still not green though, so they won't help you verify
> the correctness (https://bugs.chromium.org/p/webrtc/issues/detail?id=5195).

Cool, that's good news. I managed to generate the target and build rtc_base_objc
using gn. Updated.

[kjellander_webrtc, 2015-11-26 08:36:17]

lgtm but please address my comments.

https://codereview.webrtc.org/1467173006/diff/140001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/1467173006/diff/140001/webrtc/base/BUILD.gn#new...
webrtc/base/BUILD.gn:610: static_library("rtc_base_objc") {
I believe GN prefers source_set unless static_library is absolutely necessary. I
think they're statically linked by default anyway.

https://codereview.webrtc.org/1467173006/diff/140001/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/1467173006/diff/140001/webrtc/base/base.gyp#new...
webrtc/base/base.gyp:25: # TODO(tkchin): Mac support. There are a bunch of
problems right now because of some settings
Please wrap the comment at position 80.

[tkchin_webrtc, 2015-11-26 15:46:53]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2015-11-26 15:46:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
pthatcher@google.com, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1467173006/#ps160001 (title:
"CR comments")

[commit-bot: I haz the power, 2015-11-26 16:02:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467173006/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467173006/160001

[commit-bot: I haz the power, 2015-11-26 16:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 16:03:07]

Try jobs failed on following builders:
  android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/3583)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/5895)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/5833)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/9705)
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/10903)
  linux_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_dbg/builds/7070)
  linux_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/7060)
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_x64_dbg/bui...)
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/11121)
  mac_x64_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_rel/builds/5502)
  mac_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/10766)

[tkchin_webrtc, 2015-11-26 16:17:07]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2015-11-26 16:17:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
kjellander@webrtc.org, pthatcher@google.com
Link to the patchset: https://codereview.webrtc.org/1467173006/#ps180001 (title:
"Merge")

[commit-bot: I haz the power, 2015-11-26 16:17:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467173006/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467173006/180001

[commit-bot: I haz the power, 2015-11-26 18:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 18:17:34]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tkchin, 2015-11-26 21:26:02]

The CQ bit was checked by tkchin@chromium.org

[commit-bot: I haz the power, 2015-11-26 21:26:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467173006/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467173006/180001

[commit-bot: I haz the power, 2015-11-26 23:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 23:26:32]

Exceeded global retry quota

[kjellander_webrtc, 2015-11-27 07:15:58]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-11-27 07:16:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467173006/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467173006/180001

[commit-bot: I haz the power, 2015-11-27 07:18:26]

Description was changed from

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

Also changes presubmit script to not run cpplint on objc dirs.

BUG=
==========

to

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

Also changes presubmit script to not run cpplint on objc dirs.

BUG=
==========

[commit-bot: I haz the power, 2015-11-27 07:18:26]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2015-11-27 07:18:38]

Description was changed from

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

Also changes presubmit script to not run cpplint on objc dirs.

BUG=
==========

to

==========
Leaving all original files in talk/app/webrtc/objc until we can officially tell
clients about the new locations.

Also changes presubmit script to not run cpplint on objc dirs.

BUG=

Committed: https://crrev.com/42f580e490e8343a87362dbb20207380d850372c
Cr-Commit-Position: refs/heads/master@{#10815}
==========

[commit-bot: I haz the power, 2015-11-27 07:18:39]

Patchset 8 (id:??) landed as
https://crrev.com/42f580e490e8343a87362dbb20207380d850372c
Cr-Commit-Position: refs/heads/master@{#10815}