Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: PRESUBMIT.py

Issue 1467173006: Create webrtc/base/objc and move some logging code there (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3fdfe7fc111eea8b658a1eeb6f4eb0560674375c..52585497844aa4c58f822055522f47431b6f1f24 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -267,7 +267,14 @@ def _RunPythonTests(input_api, output_api):
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
- results.extend(_CheckApprovedFilesLintClean(input_api, output_api))
+ # Filter out files that are in objc or ios dirs from being cpplint-ed since
+ # they do not follow C++ lint rules.
+ black_list = input_api.DEFAULT_BLACK_LIST + (
+ r".*\bobjc[\\\/].*",
+ )
+ source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list)
+ results.extend(_CheckApprovedFilesLintClean(
+ input_api, output_api, source_file_filter))
results.extend(input_api.canned_checks.RunPylint(input_api, output_api,
black_list=(r'^.*gviz_api\.py$',
r'^.*gaeunit\.py$',
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698