Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1459123002: Revert of Adding thread timeout for audio recorer thread in Java (Closed)

Created:
5 years, 1 month ago by henrika_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding thread timeout for audio recorer thread in Java (patchset #2 id:20001 of https://codereview.webrtc.org/1444313002/ ) Reason for revert: Reverting since this fix might hide real issue and the reported root problem seems extremely rare. Original issue's description: > Adding thread timeout for audio recorer thread in Java > > BUG=NONE > > Committed: https://crrev.com/fd614c2149c7985bd83df809df71d0d60e5a8f74 > Cr-Commit-Position: refs/heads/master@{#10671} TBR=magjed@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/b6755ab6df946af2ceabd657f559b817276141df Cr-Commit-Position: refs/heads/master@{#10707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -179 lines) Patch
A talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java View 1 chunk +192 lines, -0 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/base/java/src/org/webrtc/ThreadUtils.java View 1 chunk +0 lines, -175 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika_webrtc
Created Revert of Adding thread timeout for audio recorer thread in Java
5 years, 1 month ago (2015-11-19 10:42:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459123002/1
5 years, 1 month ago (2015-11-19 10:43:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 10:43:15 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:43:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6755ab6df946af2ceabd657f559b817276141df
Cr-Commit-Position: refs/heads/master@{#10707}

Powered by Google App Engine
This is Rietveld 408576698