Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack.

Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack.

BUG=webrtc:4690
Committed: https://crrev.com/bd13838ccc87f94d1e951bcf780979622b020359
Cr-Commit-Position: refs/heads/master@{#10734}

[the sun, 2015-11-18 17:22:14]

Description was changed from

==========
Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack.

BUG=webrtc:4690
==========

to

==========
Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack.

BUG=webrtc:4690
==========

[the sun, 2015-11-18 17:22:14]

solenberg@webrtc.org changed reviewers:
+ noahric@chromium.org

[pthatcher1, 2015-11-18 19:26:26]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-11-18 19:26:26]

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.h (right):

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.h:124: void SetTraceOptions(const
std::string& options);   // !!!!!!!!!! Remove?
If these only have an effect when SetLogging is called and SetLogging is going
away, then yes, they should go away.

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.h:153: std::string log_options_;          
// !!!!!!!!!!! Remove?
If SetLogging is the only thing that sets it, and SetLogging is going away, then
yes, it should go away as well.

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:2340: */
Wouldn't this test just go away?

[the sun, 2015-11-19 15:55:12]

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.h (right):

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.h:124: void SetTraceOptions(const
std::string& options);   // !!!!!!!!!! Remove?
On 2015/11/18 19:26:26, pthatcher1 wrote:
> If these only have an effect when SetLogging is called and SetLogging is going
> away, then yes, they should go away.

Done.

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.h:153: std::string log_options_;          
// !!!!!!!!!!! Remove?
On 2015/11/18 19:26:26, pthatcher1 wrote:
> If SetLogging is the only thing that sets it, and SetLogging is going away,
then
> yes, it should go away as well.

Yes, as well as some other stuff.

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1457653003/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:2340: */
On 2015/11/18 19:26:26, pthatcher1 wrote:
> Wouldn't this test just go away?

Done.

[pthatcher, 2015-11-19 22:47:50]

pthatcher@google.com changed reviewers:
+ pthatcher@google.com

[pthatcher, 2015-11-19 22:47:50]

lgtm

[pthatcher, 2015-11-19 22:47:52]

lgtm

[the sun, 2015-11-20 10:44:15]

On 2015/11/19 22:47:52, pthatcher wrote:
> lgtm

Ah, I will need an LGMT from your webrtc OWNER alter ego as well...

[the sun, 2015-11-20 10:44:18]

On 2015/11/19 22:47:52, pthatcher wrote:
> lgtm

Ah, I will need an LGMT from your webrtc OWNER alter ego as well...

[pthatcher1, 2015-11-20 22:12:15]

lgtm

[the sun, 2015-11-20 22:35:26]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-11-20 22:35:26]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@google.com
Link to the patchset: https://codereview.chromium.org/1457653003/#ps120001
(title: "oops")

[commit-bot: I haz the power, 2015-11-20 22:35:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457653003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457653003/120001

[commit-bot: I haz the power, 2015-11-20 23:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 23:03:57]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-11-20 23:29:04]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-11-20 23:29:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457653003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457653003/120001

[commit-bot: I haz the power, 2015-11-21 00:08:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-21 00:08:18]

Patchset 7 (id:??) landed as
https://crrev.com/bd13838ccc87f94d1e951bcf780979622b020359
Cr-Commit-Position: refs/heads/master@{#10734}